Repository navigation
SSE3 and SSSE3 support - #11290
Merged
Merged
SSE3 and SSSE3 support#11290
Conversation
tlively
approved these changes
Jun 3, 2020
tlively
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks! cc @seanptmaher
| _mm_mulhrs_epi16(__m128i __a, __m128i __b) | ||
| { | ||
| // TODO: the following sequence oughta work, but something is not quite right, | ||
| // runtime test fails with |
Member
There was a problem hiding this comment.
Do you suspect that this is a LLVM bug?
Collaborator
Author
There was a problem hiding this comment.
I don't know - there is a possibility, although it is odd that it only caused a failure on a few specific bit patterns and not on others. Trying to extract the case to an isolated test case failed (or I failed in attempting to isolate it). Ran out of time to debug further, so had to leave it at that form for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds SSE3 and SSSE3 support, test, synthetic microbenchmark and docs.