Repository navigation
api: add autosharding load balancing policy proto - #47653
Merged
Merged
Conversation
Signed-off-by: Easwar Swaminathan <easwars@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Contributor
|
/lgtm api |
paul-r-gall
previously requested changes
Oct 13, 2026
Signed-off-by: Easwar Swaminathan <easwars@google.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The request-header field permits invalid header names and the new documentation contains a typo.
1 open finding
What changed in this PR
Adds the xDS API schema for the proposed, not-yet-implemented autosharding load-balancing policy.
Changes:
- Defines autosharding service, key, fallback, and timeout settings.
- Registers the proto package in API aggregation targets.
- Adds “autosharding” to the spelling dictionary.
| File | Description |
|---|---|
tools/spelling/spelling_dictionary.txt |
Adds the policy name. |
api/versioning/BUILD |
Includes the package in versioning. |
api/envoy/extensions/load_balancing_policies/autosharding/v3/BUILD |
Defines the generated API package. |
api/envoy/extensions/load_balancing_policies/autosharding/v3/autosharding.proto |
Defines the policy configuration. |
api/BUILD |
Includes the package in the aggregate API target. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…e standard header-name validator' Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Easwar Swaminathan <easwars@google.com>
Contributor
|
/lgtm api |
paul-r-gall
dismissed
their stale review
October 14, 2026 16:24
issues resolved via subsequent commits.
paul-r-gall
approved these changes
Oct 14, 2026
yanavlasov
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the xDS LB policy configuration protobuf message for the
autoshardingLB policy being added to gRPC as part of grpc/proposal#551.This LB policy is not currently implemented in envoy and this PR adds only the configuration message.
Risk Level: Low (API-only addition, not implemented in Envoy).
Testing: N/A (API proto definition only).
Docs Changes: Inline in proto (hidden via [#not-implemented-hide:]).
Release Notes: N/A.
@markdroth