Repository navigation
chore: avoid react linting errors - #83
Merged
amareshsm merged 2 commits intoFeb 17, 2025
Merged
Conversation
|
Hi @pkerschbaum!, thanks for the Pull Request The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.
To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page. Read more about contributing to ESLint here |
✅ Deploy Preview for eslint-code-explorer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
patricktree
marked this pull request as ready for review
February 16, 2025 14:56
nzakas
approved these changes
Feb 17, 2025
nzakas
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks!
Would like @amareshsm to review before merging.
Member
|
This change is causing some issues when typing quickly in the editor. |
amareshsm
added a commit
that referenced
this pull request
Feb 18, 2025
This reverts commit c9ada6a.
Contributor
Author
|
hmm ok, will look into this again! |
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Unblock #70 by fixing the 2 linting errors already present in the codebase.
What changes did you make? (Give an overview)
useCallbackdependenciesuseEffectfor code path on mountRelated Issues
Is there anything you'd like reviewers to focus on?