Repository navigation
Conversation
vonovak
force-pushed
the
vonovak/dependency-notice-tty
branch
from
October 9, 2026 19:04
7337ea5 to
a6c16cd
Compare
This was referenced Oct 9, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4591 +/- ##
==========================================
+ Coverage 74.46% 74.48% +0.02%
==========================================
Files 1029 1029
Lines 50390 50390
Branches 10891 10891
==========================================
+ Hits 37519 37528 +9
+ Misses 11881 11872 -9
Partials 990 990 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vonovak
added this pull request to stack #4595
October 9, 2026 19:52
vonovak
marked this pull request as ready for review
October 9, 2026 20:46
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
Contributor
|
eas-cli now uses changesets for changelogs (#4580). The required "Check for a changeset" check fails on PRs that edit To update this PR:
The release adds the PR link and the author to the entry. If this PR needs no changelog entry, revert the |
…erminal The notice is advice for a person. A program that runs eas-cli reads stderr for the command's error and found this notice first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
vonovak
force-pushed
the
vonovak/dependency-notice-tty
branch
from
October 15, 2026 14:33
6c3eff0 to
7f317ab
Compare
|
✅ Thank you for adding a changeset! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When a project has
eas-cliin its dependencies, eas-cli writes this notice to stderr before the command runs:The notice is advice for a person. A program that runs eas-cli reads stderr for the command's error, and it finds this notice first. In expo/expo-agent-cli,
status --explainshowed the notice as the reason thatbuild:listfailed.This is the first of four stacked PRs that make eas-cli output easier for programs to read: #4591 (this PR) ← #4592 writes the failure reason to stderr ← #4593 prints a JSON error with
--json← #4594 adds error codes to it.How
eas-cli prints the notice only when stderr is a terminal (
process.stderr.isTTYistrue). When stderr is a pipe or a file, eas-cli skips the notice and does not readpackage.jsonfor it.Trade-off: CI logs and EAS Build logs no longer show the notice.
I did not use
--non-interactivefor this check. That flag stops prompts, but it does not tell who reads the output. A person can pass it in a terminal, and a program can run eas-cli without it.LLM Authorship
--jsonor--non-interactive. An AI diff review found that the test failed when run in a terminal. The test now setsisTTYfor every test in the file.Test Plan
eas-cliindevDependencies, a call without a TTY prints nothing, and a later call with a TTY prints the notice. The test fails without the fix. It passes piped and in a terminal (script -q /dev/null yarn test ...).eas-cliindevDependencies, stderr captured to a file: 24.12.1 printed the notice; this branch does not.tsc,oxlintandoxfmtare clean.🤖 Generated with Claude Code