Repository navigation
fix: failing patch release bumper on missing package-lock.json - #1730
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1730 +/- ##
=======================================
Coverage 87.93% 87.93%
=======================================
Files 122 122
Lines 6848 6848
Branches 1302 1302
=======================================
Hits 6022 6022
Misses 515 515
Partials 311 311 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kriswest
left a comment
There was a problem hiding this comment.
LGTM, although co-pilot had a few suggestions you could apply:
- Check version tag doesn't already exist
if git rev-parse "v$VERSION" >/dev/null 2>&1; then echo "::error::Version v$VERSION already exists" exit 1 fi
- Verify files actually changed
git diff --quiet && { echo "::error::No version changes detected" exit 1 }
- Validate lockfile integrity
npm install --package-lock-only git diff --exit-codeFor a FINOS/open-source release process, I'd consider the "version tag already exists" check the most important omission because it prevents accidentally generating a PR for a version that's already been released.
|
@kriswest The reason the patch release wasn't working as expected is that the "Patch lockfile versions" step wasn't actually doing anything (embarrassing proof that I should pay more attention when using AI-generated code):
I figured the best choice is to extract all the repeated steps along with the script into a separate action and import that instead so that the bumper workflows don't drift... Since the |
40fb0ee to
0eaa03c
Compare
|
PR successfully generated here: #1765 |
|
@kriswest Ready to go! |
|
@kriswest Ready for a final check! |
kriswest
left a comment
There was a problem hiding this comment.
Could be validating the input version format in action.yml and teh guard on unexpected changes is a little weak, but otherwise LGTM

Description
Related Issue
Resolves #
Checklist
General
Documentation
Configuration
config.schema.json) was modified:npm run generate-config-types)npm run gen-schema-doc)Tests
npm test)npm run lintandnpm run format:check)npm run check-types)