Skip to content

fix: add checkHiddenCommits to tag push chain - #1893

Open
jescalada wants to merge 6 commits into
mainfrom
check-hidden-commits-on-tag-pushes
Open

jescalada wants to merge 6 commits into
mainfrom
check-hidden-commits-on-tag-pushes

Conversation

@jescalada

Copy link
Copy Markdown
Contributor

Description

Adds checkHiddenCommits to tag push chain, and regression tests. Tag pushes were added in 2.1 but were missing this processor. Although this appears to be a regression from GHSA-v98g-8rqx-g93g, I'm not aware of any other orgs actively using tag pushes (and even then it's hard to exploit despite the risk score).

Checklist

General

Documentation

  • Documentation has been added/updated for any new features

Tests

  • Tests have been added/updated for new functionality
  • Unit tests pass (npm test)
  • Linting and formatting pass (npm run lint and npm run format:check)
  • Type checks pass (npm run check-types)

@jescalada
jescalada requested a review from a team as a code owner November 14, 2026 08:52
@netlify

netlify Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit c8bf977
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/6afbda2677ca0a9261b8a982

@github-actions github-actions Bot added the fix label Nov 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@codecov

codecov Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.88%. Comparing base (9b2501d) to head (c8bf977).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1893      +/-   ##
==========================================
+ Coverage   88.87%   88.88%   +0.01%     
==========================================
  Files         127      127              
  Lines        7092     7092              
  Branches     1318     1318              
==========================================
+ Hits         6303     6304       +1     
  Misses        493      493              
+ Partials      296      295       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dcoric dcoric left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One ordering issue: in tagPushChainElements, checkIfWaitingAuth still runs before pullRemote, writePack and checkHiddenCommits. Once a tag push is approved, the re-push finds the approval, sets allowPush and leaves the chain before the new check. That re-push is the one forwarded upstream, so its pack is never checked for hidden commits.

The branch chain runs checkHiddenCommits before checkIfWaitingAuth. Could we move checkIfWaitingAuth after checkHiddenCommits here too, and extend the chain-order test to cover it? Everything else looks good.

@jescalada

Copy link
Copy Markdown
Contributor Author

@dcoric You're right, I didn't notice that 👍🏼 Should be good for a final look!

@jescalada

Copy link
Copy Markdown
Contributor Author

CI is failing from a Docker image fetch failure... Should be good to merge otherwise

@jescalada
jescalada requested a review from dcoric November 17, 2026 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants