Skip to content

fix(ui): display user and reviewer identities consistently - #1905

Merged
andypols merged 1 commit into
finos:mainfrom
qube-rt:fix/consistent-user-identity
Nov 18, 2026
Merged

andypols merged 1 commit into
finos:mainfrom
qube-rt:fix/consistent-user-identity

Conversation

@andypols

Copy link
Copy Markdown
Contributor

This PR makes user columns consistent across the User Activity, Repository Activity and Pushes tables.

  • Adds a shared ReviewerIdentity component.
  • Updates UserIdentity to fetch missing user data automatically from the API, including data added later when a user authenticates through SSO.
  • Adds tests for the updated behaviour.

@andypols
andypols requested a review from a team as a code owner November 17, 2026 19:51
@netlify

netlify Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit e6bde65
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/6afcb04c4e36c5b82d4c5119

@github-actions github-actions Bot added the fix label Nov 17, 2026
@codecov

codecov Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.87%. Comparing base (9b2501d) to head (e6bde65).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1905   +/-   ##
=======================================
  Coverage   88.87%   88.87%           
=======================================
  Files         127      127           
  Lines        7092     7092           
  Branches     1318     1318           
=======================================
  Hits         6303     6303           
  Misses        493      493           
  Partials      296      296           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@andypols andypols modified the milestones: 2.3.1, 2.4.0 Nov 17, 2026

@jescalada jescalada left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@andypols
andypols merged commit 6af363d into finos:main Nov 18, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants