ci(kits): diff the merge ref against the live base tip - #3084
Merged
Merged
Conversation
The three-dot form from the previous fix has no reachable merge base on a depth-1 merge-ref checkout, and its failure inside command substitution silently emptied the matrix - PRs would pass with zero kit testing. Two-dot against the freshly fetched base ref gives exactly the PR's changes for a merge-ref checkout, and the diff now runs outside the substitution so a git failure fails the step.
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3083, which traded one detection bug for a worse one: the three-dot diff has no reachable merge base on the depth-1 merge-ref checkout, and the git failure inside command substitution silently produced an empty matrix - observed live on #3066's rerun, where all kit testing was skipped while the job reported green. Two-dot against the freshly fetched live base ref is exact for a merge-ref checkout (the merge ref is built on the live tip), and the diff now runs as its own step line so a git failure fails the job instead of skipping every kit. YAML validated; the command dry-run locally against origin/kits.