Skip to content

add _66.java solution2 - #116

Merged
fishercoder1534 merged 3 commits into
fishercoder1534:masterfrom
WillShen7789:master
Oct 25, 2020
Merged

fishercoder1534 merged 3 commits into
fishercoder1534:masterfrom
WillShen7789:master

Conversation

@WillShen7789

Copy link
Copy Markdown
Contributor

No description provided.

@yaodehaung

Copy link
Copy Markdown
Contributor

@WillShen7789 great

@@ -1,5 +1,6 @@
package com.fishercoder;

import com.fishercoder.solutions._1005;

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake.

public void test1() {
digits = new int[]{9, 9, 9, 9};
assertArrayEquals(new int[]{1, 0, 0, 0, 0}, solution1.plusOne(digits));
digits = new int[]{9, 9, 9, 9};

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write new tests for solution2 so each test is responsible for only one solution. Thanks

@WillShen7789

Copy link
Copy Markdown
Contributor Author

1.write new tests for solution2
2.remove import

@fishercoder1534
fishercoder1534 merged commit 46815c1 into fishercoder1534:master Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants