Repository navigation
fix(flow-php/postgresql): parse every condition node inside AND, OR and NOT - #2727
Merged
Merged
Conversation
…nd NOT - AND/OR/NOT children parse through ConditionFactory (IS NULL, IN, bare booleans, operators, function calls, scalar subqueries) - BETWEEN SYMMETRIC parses at the top level - rebuilt BETWEEN keeps NOT and SYMMETRIC - between(not: true) produces NOT BETWEEN - unsupported-node errors name the node kind
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #2727 +/- ##
============================================
+ Coverage 90.60% 90.77% +0.16%
+ Complexity 31434 31356 -78
============================================
Files 2227 2227
Lines 90696 90563 -133
============================================
+ Hits 82175 82208 +33
+ Misses 8521 8355 -166 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #xxx
Change Log
Added
Fixed
flow-php/postgresql-AND,ORandNOTconditions parseIS NULL,IN, bare booleans, operators, function calls and scalar subqueriesflow-php/postgresql-BETWEEN SYMMETRICconditions parse from the ASTflow-php/postgresql- rebuiltBETWEENkeepsNOTandSYMMETRICflow-php/postgresql-between(not: true)producesNOT BETWEENChanged
flow-php/postgresql- unsupported condition node errors name the node kindRemoved
Deprecated
Security