Repository navigation
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces platform-specific teams (Linux, macOS, and Windows) to replace the release team, updates the teamFromString mapper to support a wider range of Flutter repositories, and refactors UpdateSuppressedTest to parse the issue repository slug and number directly from the provided issue link. The feedback recommends adding defensive checks and error handling when parsing the issue link URL to prevent unhandled exceptions, as well as expanding unit tests for teamFromString to cover edge cases like case-insensitivity and whitespace.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces platform-specific team definitions (Linux, macOS, and Windows) and updates the team mapping logic to be case-insensitive and trimmed. Additionally, it refactors the UpdateSuppressedTest handler to parse the repository slug and issue number directly from the provided issueLink URL rather than relying on the request's repository parameter, ensuring the correct GitHub service is instantiated for cross-repository issue queries. Corresponding unit tests have been added and updated to verify these changes. There are no review comments, so I have no feedback to provide.
I am working on adding support to the flaky bot for flutter/packages.
Before I get into that, I noticed some easy clean up/out of date things I could tidy up first.
Previously,
teamFromStringin test_ownership.dart only mapped four teams (framework, engine, tool, web), silently returningTeam.unknownand dropping theteam-*label for all other teams (android, ios, infra, ecosystem, etc.), while flaky_handler_utils.dart defined a non-existentteam-releaselabel and lackedteam-linux,team-macos, andteam-windows.Additionally,
UpdateSuppressedTestvalidated the GitHub issueLink by querying the test's repository (e.g. flutter/packages) rather than the repository in theissueLinkURL (flutter/flutter), where Flutter issues are tracked.Changes:
team-release(Team.release) and addteam-linux,team-macos, andteam-windowsin flaky_handler_utils.dart.teamFromString(test_ownership.dart).RepositorySlugfrom the canonicalizedissueLinkURL inUpdateSuppressedTestwhen validating that the issue exists and is open.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.