Repository navigation
[google_fonts] Migrate to material_ui & cupertino_ui #13006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,8 +4,8 @@ | |
|
|
||
| // ignore_for_file: public_member_api_docs | ||
|
|
||
| import 'package:flutter/material.dart'; | ||
| import 'package:google_fonts/google_fonts.dart'; | ||
| import 'package:material_ui/material_ui.dart'; | ||
|
Comment on lines
7
to
+8
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
|
||
| class ExampleFontSelection extends StatefulWidget { | ||
| const ExampleFontSelection({super.key}); | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,14 +3,16 @@ description: A Flutter application showcasing how to use the google_fonts packag | |
| publish_to: none | ||
|
|
||
| environment: | ||
| sdk: ^3.11.0 | ||
| sdk: ^3.13.0 | ||
| flutter: ">=3.47.0" | ||
|
|
||
| dependencies: | ||
| cupertino_icons: ^1.0.0 | ||
| flutter: | ||
| sdk: flutter | ||
| google_fonts: | ||
| path: ../ | ||
| material_ui: ^1.4.0 | ||
|
Comment on lines
14
to
+15
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
|
||
| dev_dependencies: | ||
| flutter_test: | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -4,9 +4,9 @@ | |||||||||||||
|
|
||||||||||||||
| import 'package:crypto/crypto.dart'; | ||||||||||||||
| import 'package:flutter/foundation.dart' show kIsWeb; | ||||||||||||||
| import 'package:flutter/material.dart'; | ||||||||||||||
| import 'package:flutter/services.dart'; | ||||||||||||||
| import 'package:http/http.dart' as http; | ||||||||||||||
| import 'package:material_ui/material_ui.dart'; | ||||||||||||||
|
Comment on lines
7
to
+9
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do not import
Suggested change
|
||||||||||||||
|
|
||||||||||||||
| import 'file_io.dart' // Stubbed implementation by default. | ||||||||||||||
| // Concrete implementation if File IO is available. | ||||||||||||||
|
|
||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Do you think we should mention what users should do in this changelog entry? something like:
Seems cupertino_ui exists in test/ only, so maybe no need to mention it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question, I think it's alright. Other packages that have migrated have not said so.