Repository navigation
[camera_avfoundation] Fix Swift analyzer issues in tests #13340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -117,7 +117,6 @@ final class CameraOrientationTests: XCTestCase { | |
| let (_, mockCamera, mockEventAPI, mockDevice, mockDeviceDiscoverer, _) = createCameraPlugin() | ||
| let captureSessionQueue = DispatchQueue(label: "capture_session_queue") | ||
| weak var weakPlugin: CameraPlugin? | ||
| weak var weakDevice = mockDevice | ||
|
|
||
| autoreleasepool { | ||
| let cameraPlugin = CameraPlugin( | ||
|
|
@@ -126,7 +125,7 @@ final class CameraOrientationTests: XCTestCase { | |
| globalAPI: mockEventAPI, | ||
| deviceDiscoverer: mockDeviceDiscoverer, | ||
| permissionManager: MockCameraPermissionManager(), | ||
| deviceFactory: { _ in weakDevice! }, | ||
| deviceFactory: { _ in mockDevice }, | ||
| captureSessionFactory: { MockCaptureSession() }, | ||
| captureDeviceInputFactory: MockCaptureDeviceInputFactory(), | ||
| captureSessionQueue: captureSessionQueue | ||
|
|
@@ -154,12 +153,11 @@ final class CameraOrientationTests: XCTestCase { | |
| } | ||
| } | ||
|
|
||
| weak var weakEventAPI = mockEventAPI | ||
| // Must check in captureSessionQueue since orientationChanged dispatches to this queue. | ||
| let expectation = self.expectation(description: "Dispatched to capture session queue") | ||
| captureSessionQueue.async { | ||
| XCTAssertFalse(setDeviceOrientationCalled) | ||
| XCTAssertFalse(weakEventAPI?.deviceOrientationChangedCalled ?? false) | ||
| XCTAssertFalse(mockEventAPI.deviceOrientationChangedCalled) | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bot review is right:
|
||
| expectation.fulfill() | ||
| } | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bot review is right: