Repository navigation
[flutter_svg] Add golden widget tests for SVG filters - #13658
Open
edwin-hollen wants to merge 1 commit into
Open
edwin-hollen wants to merge 1 commit into
edwin-hollen wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates flutter_svg to version 2.4.1, adding support for SVG filters including feGaussianBlur, feOffset, and feMerge. It bumps the versions of vector_graphics, vector_graphics_codec, and vector_graphics_compiler in pubspec.yaml, and adds a new group of widget tests in widget_svg_test.dart to verify the correct rendering and fallback behavior of these filters. There are no review comments, and I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds golden widget and edge-case tests in
flutter_svgfor SVG<filter>support (feGaussianBlur,feOffset,feMerge,feMergeNode), and updates dependency constraints tovector_graphics: ^1.3.0,vector_graphics_codec: ^1.2.0, andvector_graphics_compiler: ^1.3.6.Follow-up to #11909
Fixes flutter/flutter#158592
Added Golden Tests
filter.gaussian_blur.png: IsotropicfeGaussianBlur(stdDeviation="4").filter.offset.png:feOffset(dx="20",dy="15").filter.drop_shadow.png: Multi-primitive drop shadow (feGaussianBluronSourceAlpha,feOffset,feMerge).filter.gradient_drop_shadow.png: Drop shadow on a shape filled with alinearGradient.filter.group_opacity.png:<g filter="url(#...)" opacity="0.5">compositing a multi-layer filter once under group opacity.filter.anisotropic_blur.png: DirectionalfeGaussianBlur(stdDeviation="12 1").filter.scaled_transform.png: Drop shadow under<g transform="scale(2)">scaling blur and offset proportionally.Also adds widget tests for
stdDeviation="0", negativefeOffset(dx/dy), and mixed unsupported filter fallback (feFlood+feGaussianBlur).Pre-launch Checklist
///).