Repository navigation
Conversation
Before calling TestSub, historically we have re-placed the WorkPointer after the active term, but only if it sits before the term's end. If it points beyond the end of the active term, that additional space is lost, leading to rapid consumption of the WorkSpace, particularly with Repeat constructions. It seems rather sure that no active data lies beyond the term here; we are about to call TestSub, which is free to expand the size of the term if certain substitutions are made, for example. But if it turns out that a bisection leads back here, we need to investigate very carefully. Note that following the call to TestSub, there may indeed be active data in the WorkSpace following the term: it sets AT.TMaddr and AN.Frozen. Resetting WorkPointer after the TestSub call just after this edit does actually appear to be safe, but resetting it after the TestSub call on entry to Generator is certainly wrong. Fixes form-dev#873
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before calling TestSub, historically we have re-placed the WorkPointer after the active term, but only if it sits before the term's end. If it points beyond the end of the active term, that additional space is lost, leading to rapid consumption of the WorkSpace, particularly with Repeat constructions.
It seems rather sure that no active data lies beyond the term here; we are about to call TestSub, which is free to expand the size of the term if certain substitutions are made, for example. But if it turns out that a bisection leads back here, we need to investigate very carefully.
Note that following the call to TestSub, there may indeed be active data in the WorkSpace following the term: it sets AT.TMaddr and AN.Frozen. Resetting WorkPointer after the TestSub call just after this edit does actually appear to be safe, but resetting it after the TestSub call on entry to Generator is certainly wrong.
Fixes #873