React 15.5 compatibility by inukshuk · Pull Request #918 · formatjs/formatjs

inukshuk · 2017-04-08T12:05:12Z

Thanks for react-intl! This PR just imports PropTypes from 'prop-types' package as suggested by React 15.5 and later.

React 15.5 compatibility.

React 0.14.9 supports the separate prop-types module required by 0.15.5 and later.

Starting with React 15.5 `createRenderer` is provided by react-test-renderer.

React 15.5 and later exports `createRenderer` via 'react-test-renderer' while React 14 uses 'react-addons-test-utils'. Because of the static nature of ES6 import statements we cannot conditionally import from different modules depending on React versions; therefore, this commit adds an NPM pretest script to generate 'test/renderer.js' which simply imports the right module for the current React version. This is to make sure tests work with both `npm run react:14` and `npm run react:15`, but ideally should be dropped once support for React 14 is dropped.

inukshuk · 2017-04-13T09:31:06Z

I also updated the examples to use 'prop-types' and changed the minimum peer dependency of React to version 0.14.9 (which is compatible with the 'prop-types' module).

I was a bit puzzled how to make the tests work with both React 14 and 15.5+ without deprecation messages. ES6 import statements must be static and at the top-level so we cannot conditionally import createRenderer from either 'react-addons-test-utils' (for React 14) or 'react-test-renderer/shallow' (for React 15). For the time being I solved this by creating 'test/renderer.js' in an NPM pretest script to make sure all tests continue to work for the react:14 and react:15 targets but I'd be happy if anyone could suggest a better solution. (Or if the react:14 tests can be dropped)

antoinerousseau · 2017-04-13T12:10:09Z

@@ -1,4 +1,5 @@
-import React, {Component, PropTypes} from 'react';
+import React, {Component} from 'react';
+import {PropTypes} from 'prop-types';


why brackets?
https://github.com/reactjs/prop-types#importing

Good question! I must be going blind.

bjankord · 2017-04-13T17:03:41Z

@inukshuk This was a solution I saw from @kentcdodds to handle importing different packages based on what version of react was used. This idea could be used to conditionally import createRenderer from either 'react-addons-test-utils' (for React 14) or 'react-test-renderer/shallow' (for React 15)

inukshuk · 2017-04-13T19:09:23Z

@bjankord cool thanks!

Are the tests ever compiled to something other than commonjs modules? If that's not a requirement we can just use require directly -- that's much better!

inukshuk · 2017-04-13T19:42:07Z

Alright, followed @bjankord's suggestion and used require directly; I think this should cover all compatibility issues now.

quantizor · 2017-04-17T16:08:44Z

@ericf could you take a look at this please? FB shows console errors for these deprecations and it adds gross noise when trying to develop / debug

eMarek · 2017-04-19T14:23:57Z

Any plans when this will be merged or have I missed something that we are waiting for?

MichaelDeBoey · 2017-04-21T08:08:34Z

@ericf I think this can be merged?

tswaters · 2017-04-22T07:25:02Z

Last commit from @ericf was almost a month ago, updating contributing docs for posting a new release.

Also there's this: https://ericf.me/apple. I'm not sure if ericf is working on this project any longer and/or there are any other contributors.... most of the time I see someone with a contributor badge it's ericf.

MichaelDeBoey · 2017-04-22T13:01:46Z

@antoinerousseau is the reviewer, so maybe he can merge it then?
Or maybe @ericf knows who's following up this project in this place?

quantizor · 2017-04-24T07:30:04Z

I wouldn't hold your breath for him to respond, tbh. Yahoo is all but dead at this point, would be nice if the FB open source team might be interested in taking it over? @gaearon

MichaelDeBoey · 2017-04-24T07:50:02Z

That could indeed be another possibility @probablyup :-)

gaearon · 2017-04-24T10:35:03Z

We don’t really “take over” projects from other companies—and we also don’t maintain anything that we aren’t actively using in production. We have our own internalization infra at Facebook so it wouldn’t make sense for us to steer react-intl. If there is a need for a new maintainer, perhaps you could raise an issue? I’m sure some of the large companies using it could volunteer to help!

okuryu · 2017-04-24T12:11:47Z

Just the other day I got a commit bit for react-intl from @ericf and @redonkulus (from Yahoo) to maintain react-intl. I have told them I would like to help this project. I think this change is a high priority for us, but please give me a little time to review this change and prepare to release a new version.

All feedbacks about this change are always welcome, please post your thoughts if you have any concern or idea.

bjankord · 2017-04-24T14:10:48Z

Thanks for the update @okuryu!

MichaelDeBoey · 2017-04-27T19:00:47Z

Any news on this one @okuryu? 🙂

lyushenko · 2017-04-28T09:56:18Z

We are slightly blocked by this issue and I'd like to contribute if you need any help @okuryu

bjankord · 2017-04-30T13:21:58Z

Any update on this? @ericf @okuryu This is the last dependency I need updated to have react 15.5 compatibility before I can update to react 15.5.

mikebridge · 2017-05-01T15:05:32Z

This is a trivial PR that remains unmerged after three weeks. Is this project still active or is it a victim of Yahoo's collapse?

bmv437 · 2017-05-01T15:33:17Z

@mikebridge please read this comments above. Specifically this one. I expect @okuryu will merge this PR soon and cut a new release.

mikebridge · 2017-05-01T16:15:07Z

@bmv437 Thanks, I have read the comments which is why I'm concerned. I've only just started using react-intl, and I now get the impression that the core team has suddenly left the project—is this not correct?

okuryu · 2017-05-03T13:01:28Z

Okay, I've merged. I'll release a new version within a week.

gaearon · 2017-05-03T13:31:36Z

Just to be clear, this is really more of a 16 than 15.5 compatibility. Your apps will work even with warnings—it’s nice to gradually fix them as we move towards 16, but I think it’s also unnecessary to exert so much pressure on library maintainers right now. This change is not urgent.

robcaldecott · 2017-05-03T16:12:21Z

Understood 100% but as this warning takes the form of a console error it causes tests to fail. Does anyone know of a good workaround for this?

lyushenko · 2017-05-03T20:07:32Z

@robcaldecott you can use the production version of React to suppress console errors or install a fork temporarily:

"react-intl": "inukshuk/react-intl"

However, it would be better if React logged warnings instead of errors (console.warn)

quantizor · 2017-05-03T20:09:19Z

Agreed. I raised a PR about that in fbjs and they rejected it.

…

On Wed, May 3, 2017 at 4:07 PM Eugene Lyushenko ***@***.***> wrote: @robcaldecott <https://github.com/robcaldecott> you can use the production version of React to suppress console errors or install a fork temporarily: "react-intl": "inukshuk/react-intl" However, it would be better if React logged warnings instead of errors ( console.warn) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#918 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAiy1gmbDjJ_kInG1bcJy9JaAz5mQEzzks5r2N6IgaJpZM4M3ryb> .

robcaldecott · 2017-05-03T21:10:58Z

I use create-react-app and that does not come with Jest configured to use the production version of React. I'll try setting NODE_ENV and see if that works.

gaearon · 2017-05-03T21:40:31Z

I don't think console.error causes tests to fail in Create React App. What gave you that impression?

However, it would be better if React logged warnings instead of errors

It's planned for 15.6.

gaearon · 2017-05-03T21:43:41Z

(If it does cause CRA tests to fail please raise an issue with CRA. This was never intended. In general when you see weird behavior please raise issues rather than silently accept it 😉 )

robcaldecott · 2017-05-03T21:49:56Z

On Windows with CI=true it returns an ERRORLEVEL of 1. I'll raise a PR. Weirdly it does not do this if you pass -- --coverage to npm test.

lyushenko · 2017-05-03T21:56:50Z

@gaearon in our case, we're using Capybara to run feature tests and it is set up to capture all JS errors and our tests are failing due to deprecation warning. No big deal though, we kinda "hacked" it :)

gaearon · 2017-05-03T21:57:06Z

Interesting. Please do raise it, thanks!

inukshuk added 3 commits April 8, 2017 13:56

Use PropTypes from 'prop-types'

859ed78

React 15.5 compatibility.

Add 'prop-types' as dev dependency

02d8ce1

Declare 'prop-types' as an external dependency

ad1b725

ghostd mentioned this pull request Apr 10, 2017

React ^15.5.0 support? #922

Closed

inukshuk added 4 commits April 13, 2017 09:10

Updtate React 0.14.x peer dependency

9a8c5ed

React 0.14.9 supports the separate prop-types module required by 0.15.5 and later.

Use 'prop-types' module in examples

4a1e291

Use react-test-renderer

ba14f65

Starting with React 15.5 `createRenderer` is provided by react-test-renderer.

inukshuk changed the title ~~React 15.5 compatibility: Use PropTypes from 'prop-types'~~ React 15.5 compatibility Apr 13, 2017

antoinerousseau reviewed Apr 13, 2017

View reviewed changes

Remove brackets from PropTypes import

81ea58c

Dynamically createRenderer based on React version

e749a38

ratson mentioned this pull request Apr 19, 2017

Support React 15.5.0 ratson/react-intl-redux#32

Merged

MichaelDeBoey mentioned this pull request Apr 24, 2017

React 15.5.X #931

Closed

thellimist mentioned this pull request May 1, 2017

Jwineman/react155 cloudflare/cloudflare-plugin-frontend#125

Merged

okuryu approved these changes May 3, 2017

View reviewed changes

okuryu merged commit 4c7a766 into formatjs:master May 3, 2017

thellimist mentioned this pull request May 3, 2017

Upgrade to React 15.5 cloudflare/cloudflare-plugin-frontend#117

Closed

bjankord mentioned this pull request May 3, 2017

React 15.5 upgrade cerner/terra-core#203

Closed

11 tasks done

MichaelDeBoey mentioned this pull request May 4, 2017

Accessing PropTypes via the main React package is deprecated #933

Closed

ezzatron mentioned this pull request May 6, 2017

React 15.5.x: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead. grommet/grommet#1303

Closed

Conversation

inukshuk commented Apr 8, 2017

Uh oh!

inukshuk commented Apr 13, 2017

Uh oh!

antoinerousseau Apr 13, 2017

Choose a reason for hiding this comment

Uh oh!

inukshuk Apr 13, 2017

Choose a reason for hiding this comment

Uh oh!

bjankord commented Apr 13, 2017

Uh oh!

inukshuk commented Apr 13, 2017

Uh oh!

inukshuk commented Apr 13, 2017

Uh oh!

quantizor commented Apr 17, 2017

Uh oh!

eMarek commented Apr 19, 2017

Uh oh!

MichaelDeBoey commented Apr 21, 2017

Uh oh!

tswaters commented Apr 22, 2017

Uh oh!

MichaelDeBoey commented Apr 22, 2017

Uh oh!

quantizor commented Apr 24, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MichaelDeBoey commented Apr 24, 2017

Uh oh!

gaearon commented Apr 24, 2017

Uh oh!

okuryu commented Apr 24, 2017

Uh oh!

bjankord commented Apr 24, 2017

Uh oh!

MichaelDeBoey commented Apr 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lyushenko commented Apr 28, 2017

Uh oh!

bjankord commented Apr 30, 2017

Uh oh!

mikebridge commented May 1, 2017

Uh oh!

bmv437 commented May 1, 2017

Uh oh!

mikebridge commented May 1, 2017

Uh oh!

okuryu commented May 3, 2017

Uh oh!

gaearon commented May 3, 2017

Uh oh!

robcaldecott commented May 3, 2017

Uh oh!

lyushenko commented May 3, 2017

Uh oh!

quantizor commented May 3, 2017 via email

Uh oh!

robcaldecott commented May 3, 2017

Uh oh!

gaearon commented May 3, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gaearon commented May 3, 2017

Uh oh!

robcaldecott commented May 3, 2017

Uh oh!

lyushenko commented May 3, 2017

Uh oh!

gaearon commented May 3, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

quantizor commented Apr 24, 2017 •

edited

Loading

MichaelDeBoey commented Apr 27, 2017 •

edited

Loading

gaearon commented May 3, 2017 •

edited

Loading