Skip to content

update ProvidedTypes form FSharp.Data - #48

Merged
vasily-kirichenko merged 2 commits into
fsprojects:masterfrom
vasily-kirichenko:update-ProvidedTypes-fix-memory-leak
Dec 12, 2014
Merged

vasily-kirichenko merged 2 commits into
fsprojects:masterfrom
vasily-kirichenko:update-ProvidedTypes-fix-memory-leak

Conversation

@vasily-kirichenko

Copy link
Copy Markdown
Contributor

fix memory leak caused by hiding Disposable member implemented in ProvidedTypes.

@forki @dungpa I'm not sure it's totally OK that I pick ProvidedTypes.fs/fsi from FSharp.Data repository. Where can I get the latest vanilla ProvidedTypes?

fix memory leak caused by hiding Disposable member implemented in ProvidedTypes
@dsyme

dsyme commented Dec 12, 2014

Copy link
Copy Markdown
Contributor

In theory the latest is the one in the F# Type Provider Starter Pack.

@sergey-tihon

Copy link
Copy Markdown
Member

As I know the latest version is it FSharp.TypeProviders.StarterPack. Am I right @mavnn?

@vasily-kirichenko Now you have a unique possibility to reference latest version using Paket.
Example is here - https://github.com/mavnn/Inrush/blob/master/paket.dependencies#L13

@dsyme

dsyme commented Dec 12, 2014

Copy link
Copy Markdown
Contributor

It would be great to get the Travis build fixed - any idea what this error is? https://travis-ci.org/fsprojects/FSharp.Configuration/builds/43840015#L467

@dungpa

dungpa commented Dec 12, 2014

Copy link
Copy Markdown

I think FSharp.TypeProviders.StarterPack has the latest bits. @ReedCopsey did a PR fsprojects/FSharp.TypeProviders.SDK#23 to fix potential memory leaks there a few months ago.

@sergey-tihon

Copy link
Copy Markdown
Member

I think that we should mention in README.md of FSharp.TypeProviders.StarterPack
That is it official home for ProvidedTypes and repo contains latest version of files.

Your thoughts? @dsyme @mavnn @ReedCopsey @dungpa

@dsyme

dsyme commented Dec 12, 2014

Copy link
Copy Markdown
Contributor

Yes, please do that. See also this discussion: fsprojects-archive/zzarchive-VisualFSharpPowerTools#474 (comment)

@mavnn

mavnn commented Dec 12, 2014

Copy link
Copy Markdown

Sounds good. I'm feeling somewhat ill at the moment: if anyone gets around
to sending a pull request I'll try and make sure I merge it.
On 12 Dec 2014 14:51, "Sergey Tihon" notifications@github.com wrote:

I think that we should mention in README.md of
FSharp.TypeProviders.StarterPack
That is it official home for ProvidedTypes.fs and repo contains latest
version of files.

Your thoughts? @dsyme https://github.com/dsyme @mavnn
https://github.com/mavnn @ReedCopsey https://github.com/ReedCopsey
@dungpa https://github.com/dungpa

—
Reply to this email directly or view it on GitHub
#48 (comment)
.

vasily-kirichenko added a commit that referenced this pull request Dec 12, 2014
…x-memory-leak

update ProvidedTypes form FSharp.Data
@vasily-kirichenko
vasily-kirichenko merged commit f81cb93 into fsprojects:master Dec 12, 2014
@vasily-kirichenko

Copy link
Copy Markdown
Contributor Author

Published in NuGet package 0.4.7

vasily-kirichenko pushed a commit to vasily-kirichenko/FSharp.Configuration that referenced this pull request May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants