Repository navigation
Fix the prefix for three-byte ECI assignments - #239
Open
mikamikasuki wants to merge 1 commit into
Open
mikamikasuki wants to merge 1 commit into
mikamikasuki wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ECI assignments from 16384 through 999999 require a three-byte designator beginning with
110. The current constant places those prefix bits one hexadecimal digit too low. Change0xc0000to0xc00000.Add bitstream checks for assignments 0, 127, 128, 16383, 16384, and 999999, covering every length boundary and the maximum accepted value. The two three-byte cases fail before the fix.
Validation on macOS with Apple Clang 16:
-Wall -Wextra -Werror -pedantic-errors. Its complete QR symbols match the Nayuki encoder for 48 accepted ECI values with fixed version, error correction, mask, and payload.Fixes #223.
Prepared with AI assistance.