Repository navigation
Test fixes for PR 87 - #1
Merged
Merged
Conversation
Python 3 supports keyword arguments to `zlib.compressobj`. However it seems Python 2 does not. Fortunately Python 2 does support the arguments that were supplied here, just as conditional arguments. This converts the function into one using positional arguments, which should smooth over the Python 2/3 differences.
As this PR includes a fix for `gzip` handling (namely that it differs from `zlib` by a header), this test is no longer accurate. So we correct it to use the correct ID.
8 tasks
alimanfoo
reviewed
Oct 19, 2018
| @@ -55,7 +55,7 @@ def test_repr(): | |||
|
|
|||
|
|
|||
| def test_alias(): | |||
There was a problem hiding this comment.
Can we not drop this test entirely if 'gzip' is no longer an alias for 'zlib'?
Owner
There was a problem hiding this comment.
Yes, I guess that would make sense.
Author
There was a problem hiding this comment.
Definitely. That was the other route I was debating, but wanted you to confirm. 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a couple test fixes for PR ( zarr-developers#87 ) as discussed in that PR.