Skip to content

Added youtube video embedding to simulate - #251

Merged
atharva-bhange merged 1 commit into
devfrom
feature/simulate-yt-video-embedding
Sep 25, 2025
Merged

atharva-bhange merged 1 commit into
devfrom
feature/simulate-yt-video-embedding

Conversation

@khushalsonawat

Copy link
Copy Markdown
Member

Pull Request

Description

Describe the changes in this pull request:

  • What feature/bug does this PR address?
  • Provide any relevant links or screenshots.

Checklist

  • Code compiles correctly.
  • Created/updated tests.
  • Linting and formatting applied.
  • Documentation updated.

Related Issues

Closes #<issue_number>

@khushalsonawat khushalsonawat self-assigned this Sep 25, 2025
@atharva-bhange
atharva-bhange merged commit 2a995f2 into dev Sep 25, 2025
@atharva-bhange
atharva-bhange deleted the feature/simulate-yt-video-embedding branch September 25, 2025 06:43
@khushalsonawat
khushalsonawat restored the feature/simulate-yt-video-embedding branch September 25, 2025 07:11
nik13 added a commit that referenced this pull request Oct 15, 2026
…s (TH-8262)

Review fixes for #915, matching traceAI#251 at its new head:
- Privacy: with outputs hidden, a thrown error exports only its class
  and a fixed summary (no stderr, no stack trace); turn.failed and fatal
  error events give a fixed label. Lists the error text that is content
  (binary stderr with paths and user name, provider error bodies, stack
  traces, error item text) and says opt-in exports it.
- Install note: the package ships with traceAI PR #251; install from
  source until it is on npm (recipe verified: clone, build, pack, install).
- What is captured: error events are retries unless the turn never
  completes (codex.stream_error.count); error items are warnings with
  status unset; the turn opens on the first read, thread.started sets
  session.id.
- Cancelled only on break/return()/abort; a dropped iterator exports
  nothing. Failed or cancelled turns' tokens land on the next completed
  turn. Token handling verified on 0.162.1 only; Thread shape versions
  listed.
- Troubleshooting: register() throws without a project name; the
  manuallyInstrument() warning needs a diag logger; stream_error count
  on OK turns; summary-only error messages.
- FI_HIDE_* wording, Codex SDK doc link (now learn.chatgpt.com),
  subagent (collab_tool_call) and provider limitations.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants