Repository navigation
fix(java-core): maintain native Arconia error privacy in shared core - #334
Merged
Merged
Conversation
Move the copied exporter filter into the existing Java core artifact with an explicit Spring import. Preserve native SDK ownership, pre-egress error privacy, raw opt-in, and the legacy example entry point. Cover floor/current Arconia OTLP output and core lifecycle contracts. Co-Authored-By: Claude Code <noreply@anthropic.com>
Build the shared privacy dependency from the PR checkout before compiling the standalone Arconia example, rather than resolving an older registry release. Co-Authored-By: Claude Code <noreply@anthropic.com>
This was referenced Oct 31, 2026
Open
Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
Add a job-scoped regression contract for both independently added Java CI jobs, covering their matrices, toolchains, test commands, and report uploads. Co-Authored-By: Claude Code <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep Arconia's native OpenTelemetry route; replace the copied error-redaction implementation with a maintained component in the existing
traceai-java-coreartifact. There is no new Arconia instrumentation package, provider, exporter or span processor.ErrorDetailRedactingSpanExporterfor framework-owned SDKs, and an explicitly importedErrorDetailRedactionConfigurationfor Spring-managed exporters.FI_EXPORT_ERROR_DETAILS=true, existing TraceAI APIs and the example's old configuration entry point (now a deprecated forwarding import). Do not change FITracer's separateFI_HIDE_ERROR_DETAILSbehavior.Reproduction and validation
Baseline: dev
8600a66c1a692f44a9f937640bb4c3ecbd42c98d.Removing the original copied helper makes the existing OTLP-wire privacy test fail on both Arconia 0.30.0 and 0.31.0:
exception message is not exported ==> expected: <false> but was: <true>. Keeping the old helper passes. Deleting the privacy prerequisite without a replacement is therefore not safe.All runtime tests below ran offline under the supplied macOS sandbox denying outbound network except loopback (Java IPv4 preference enabled for the loopback rule):
mvn verify: passed (182 discovered, 73 passed, 109 credential-gated tests skipped).No vendor or model API was called. No versions or changelog version sections were manually changed.
Documentation and release sequencing
No docs PR yet. Maven Central currently publishes Java core 1.0.0 without this API. Keep the current privacy prerequisite live until the core change is released. The follow-up guide replaces the copied class with the dependency plus a single
@Import, and must use the actual released version before publication. No claim of Spring AI model-tracing compatibility is added; this remains native HTTP tracing.Scope checks
Open traceAI PRs #204 and #301 and docs PR #989 do not already implement this shared Arconia privacy replacement. Existing in-flight Spring AI work is untouched.
Current-dev follow-up (2026-11-02)
Merged
origin/devnormally, preserving both the Arconia core-install and Quarkus native-adapter install steps. Added a CI regression test that failed against dev's one-sided workflow and passes with both. This resolves the review's CI conflict without dropping either prerequisite.Maven Central now publishes Arconia 0.32.0 (new latest). It fixes the documented
http-protobufspelling that silently disabled export in 0.30.0/0.31.0; the old expectation failed first against 0.32.0, then the version-aware contract and README were corrected. Native Arconia tests passed at the declared floor 0.30.0 and latest 0.32.0 (13 each); merged Java core passed at its OTel 1.35.0 floor and 1.67.0 (56 tests each). Integration planner tests passed (17). All runtime tests used local loopback receivers and an outbound-denying sandbox; no live credentials. Original dev at12c23513still leaks error messages if the copied helper is removed: the existing wire test failed withexception message is not exported ==> expected: <false> but was: <true>.The earlier reproduction and test counts above describe the historical first PR head, not this follow-up head. Public documentation still waits for the shared core API to be released; do not publish the held guide against Maven Central's older artifact.
🤖 Generated with Claude Code