Repository navigation
Fix ACP file-write success response - #3922
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
Nothing to really note.
What was wrong
BB returned
nullafter successful ACP file writes, violating the object response schema and causing strict clients to report parse errors (#3453).What changed
Return
{}and strengthen the existing test fixture to reject invalid responses, with regression coverage for file creation and updates; no server/daemon protocol, CLI, or documentation changes required.How you verified
Both human and agent verified.
pnpm exec turbo run test typecheck --filter=@bb/provider-bridge-acp: 320 tests passed; typecheck passedgit diff --check: passedFixes #3453.