Repository navigation
Support Dia and discover compatible browser cookie stores - #4092
Merged
Merged
Conversation
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
Couldn't find Dia when looking on browsers, and found a hardcoded browser list. Support auto-discover for browsers that are Firefox / Chromium / ... -based else hard-code it.
What was wrong
Browser cookie import depended on a fixed registry, leaving Dia and unlisted Chromium or Firefox browsers unavailable even when their cookie storage was compatible.
What changed
Add native Dia and Zen entries and combine the existing registry with bounded discovery of compatible stores belonging to registered web browsers. Preserve known encryption identities, exclude BB and non-browser stores, and revalidate discovered sources before import. Avoid Keychain lookups for plaintext stores and reject unsupported versioned ciphertext.
Accept opaque discovered source IDs across the desktop contract and bump
HOST_DAEMON_PROTOCOL_VERSIONfrom 216 to 217. Update CLI/SDK guide surfaces and document Linux XDG, Flatpak, Snap, and encryption limitations.How you verified
Both human and agent verified.
pnpm exec turbo run test --filter=@bb/desktop -- browser-import.test.ts browser-applications.test.ts desktop-browser-broker-import.test.ts— 41 tests passed after cleanup.pnpm exec turbo run test --filter=@bb/app -- BrowserSettingsSection.test.tsx— 6 tests passed after cleanup.pnpm exec turbo run typecheck --filter=@bb/desktop --filter=@bb/plugin-api-map— passed after merging main.pnpm exec turbo run test --filter=@bb/host-daemon-contract -- desktop-browser.test.ts— 6 tests passed after merging main.git diff --checkpassed.