Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
The plan checks attachments page loads, SDK section loads, 404s, and client errors. An issue escalates when that page 404s or client errors rise. Services: Mention PlanWhat changedThe Attachments spec page now documents a draft flamegraph attachment contract. Requests to RiskA compile or render failure can 404 this spec page. A new code block or spec badge can throw a client TypeError. Sibling Intended effectThis is a documentation spec. Telemetry cannot prove the new flamegraph text is on the page. A successful load of
Regression watchA bad MDX render can 404 this page or throw in the shared spec renderer. Watch client errors first. Then watch 404s on the SDK telemetry family.
If the error rate rises, check client stacks from code tabs and spec badges on Not observableThe flamegraph section body, the 1.8.0 spec badge, and the example JSON on the rendered page. Pageload and navigation span duration: production queries for |
|
|
||
| Event context such as release, environment, SDK identity, device, OS, and hang duration belongs on the associated event. Symbolication inputs belong in the attachment so they remain available when the diagnostic describes a different process run from the uploading SDK. | ||
|
|
||
| #### Flamegraph Payload |
There was a problem hiding this comment.
I assume the flamegraph does not contain sensitive data, i.e. requires no PII scrubbing?
There was a problem hiding this comment.
We currently don’t scrub profiling profile chunks, and standard error-event scrubbing excludes source paths and debug metadata.
Therefore I don’t think flamegraphs require a dedicated default scrubber either.
DESCRIBE YOUR PR
Define the draft
event.flamegraphattachment contract in Attachments specification 1.8.0. SDKs sendflamegraph.jsonalongside an event, containing aggregated caller-to-callee trees, a shared frame table, and debug metadata for symbolication. This is a documentation proposal, not an implementation of ingestion or processing support.Schema Decisions
debug_meta. Binary identity and address metadata are necessary for later symbolication, including diagnostics captured in a different process run from the uploading SDK. Keep event context on the event rather than defining a second device/OS metadata schema.thread_attributedrecords source attribution when known.Limits and Processing Decisions
_should_symbolicateand_symbolicate_profileskip symbolication afterprocessed_by_symbolicatoris set. Its sample-result processing replaces frame entries and remaps stacks for inline frames. The flamegraph contract adopts the same once-per-processed-payload principle. A deliberate rerun must start from unexpanded input.Review focus is agreement on:
IS YOUR CHANGE URGENT?
PRE-MERGE CHECKLIST