Skip to content

ci(craft): require craft 3.0.0 for per-package NuGet publishing - #5770

Closed
ric-oliv wants to merge 3 commits into
mainfrom
ci/craft-min-version
Closed

ric-oliv wants to merge 3 commits into
mainfrom
ci/craft-min-version

Conversation

@ric-oliv

@ric-oliv ric-oliv commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

Follow-up to #5753. Burak suggested bumping minVersion in his review there, and this does that.

#5753 turned on the nuget target's workspaces mode from getsentry/craft#686. A craft version without #686 doesn't know these keys. It ignores them and publishes every package through a single nuget target with --skip-duplicate, and the release still succeeds. So if an older craft ever runs our release, nothing tells us it took the old path.

This sets minVersion to 3.0.0. #686 is a feat(nuget)!: change, and craft's auto versioning turns a ! title into a major bump. The Semver Impact check on #686 says Major too. So the release that ships it should be 3.0.0, and an older craft now stops with a config error instead of quietly publishing the old way.

The bump doesn't change anything else craft does for us. Craft gates a few defaults on minVersion. Auto versioning (2.14.0) and automatic version bumping (2.21.0) were already on at 2.26.3. The only new gate this crosses is 2.29.0, which is for the top-level workspaces key, and we don't use that one.

Blocked until craft 3.0.0 is out

Craft hasn't released #686 yet. The latest release is 2.35.1, and our release.yml still pins 2.34.1. With this change alone, craft prepare would fail the version check. So this stays a draft until craft cuts the release. Then I'll:

  • pin getsentry/craft in release.yml to the 3.0.0 release commit
  • change minVersion here if the release ends up with a different number

What I checked

  • Published craft 2.35.1 rejects the config: Incompatible "craft" versions. Current version: 2.35.1 (0ff7589...), minimal version: 3.0.0 (taken from .craft.yml).
  • I built craft master, which has Fix NLog failing tests #686, with its version set to 3.0.0 and ran craft targets on this branch without submodules. It accepts the config and lists 23 nuget[...] targets plus github and registry. That's the 22 from ci(craft): publish each NuGet package as its own craft target #5753 plus Sentry.Quartz, which landed on main since then and which the filters already pick up.

#skip-changelog

…r target

#5753 turned on the nuget target's workspaces mode, which comes from
getsentry/craft#686. A craft version without #686 ignores the new keys
and publishes every package through a single nuget target with
--skip-duplicate. The release still succeeds, so nobody would notice
it ran on the old path.

#686 is marked as a breaking change, so craft's auto versioning makes
its release 3.0.0. With minVersion set to 3.0.0, an older craft refuses
the config with a clear error instead.

Craft 3.0.0 isn't out yet. Until release.yml pins it, craft prepare
fails this check, so the pin has to move before this merges.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ric-oliv
ric-oliv marked this pull request as ready for review October 22, 2026 07:58
@github-actions github-actions Bot added the risk: medium PR risk score: medium label Oct 22, 2026
@ric-oliv
ric-oliv requested a review from BYK October 22, 2026 08:03
@codecov

codecov Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.20%. Comparing base (04cac0d) to head (8e9d4ad).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5770      +/-   ##
==========================================
+ Coverage   76.13%   76.20%   +0.07%     
==========================================
  Files         528      528              
  Lines       19579    19579              
  Branches     3829     3829              
==========================================
+ Hits        14906    14921      +15     
+ Misses       3791     3776      -15     
  Partials      882      882              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added risk: high PR risk score: high and removed risk: medium PR risk score: medium labels Oct 22, 2026
This reverts commit 03378e5.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added risk: medium PR risk score: medium and removed risk: high PR risk score: high labels Oct 22, 2026
Comment thread .craft.yml
@@ -1,4 +1,4 @@
minVersion: 2.26.3
minVersion: 3.0.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release workflow runs Craft below the required minimum version

.craft.yml now requires Craft 3.0.0, but .github/workflows/release.yml still pins the release action to Craft 2.34.1. Running the release workflow will fail Craft’s minimum-version validation before the release can proceed. Update the action pin to a 3.0.0-or-later release.

Evidence
  • .craft.yml sets minVersion: 3.0.0.
  • The Prepare release step in .github/workflows/release.yml invokes getsentry/craft at the pinned 2.34.1 commit.
  • That pinned version is below the configured minimum, so the release step fails minimum-version validation.

Identified by Warden · code-review · Y8H-8SX

@jamescrosswell

Copy link
Copy Markdown
Collaborator

@ric-oliv I think this one can be closed in favour of #5775. Craft 3.0.0 shipped on 2026-10-22 with getsentry/craft#686 in it, and #5775 makes both changes this PR was waiting to make: minVersion: 3.0.0 and moving the release.yml pin off 2.34.1. It also switches us to craft's built-in VersionPrefix bumping (getsentry/craft#923), so the two PRs would only conflict. The guard you suggested in #5753 is still there in #5775: a craft older than 3.0.0 stops with a config error instead of quietly publishing the old way.

Any objection to closing this one?

@ric-oliv

Copy link
Copy Markdown
Member Author

Sounds good! Closed!

@ric-oliv ric-oliv closed this Oct 23, 2026
@ric-oliv
ric-oliv deleted the ci/craft-min-version branch October 27, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: medium PR risk score: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants