Repository navigation
Conversation
…r target #5753 turned on the nuget target's workspaces mode, which comes from getsentry/craft#686. A craft version without #686 ignores the new keys and publishes every package through a single nuget target with --skip-duplicate. The release still succeeds, so nobody would notice it ran on the old path. #686 is marked as a breaking change, so craft's auto versioning makes its release 3.0.0. With minVersion set to 3.0.0, an older craft refuses the config with a clear error instead. Craft 3.0.0 isn't out yet. Until release.yml pins it, craft prepare fails this check, so the pin has to move before this merges. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5770 +/- ##
==========================================
+ Coverage 76.13% 76.20% +0.07%
==========================================
Files 528 528
Lines 19579 19579
Branches 3829 3829
==========================================
+ Hits 14906 14921 +15
+ Misses 3791 3776 -15
Partials 882 882 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This reverts commit 03378e5. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
| @@ -1,4 +1,4 @@ | |||
| minVersion: 2.26.3 | |||
| minVersion: 3.0.0 | |||
There was a problem hiding this comment.
Release workflow runs Craft below the required minimum version
.craft.yml now requires Craft 3.0.0, but .github/workflows/release.yml still pins the release action to Craft 2.34.1. Running the release workflow will fail Craft’s minimum-version validation before the release can proceed. Update the action pin to a 3.0.0-or-later release.
Evidence
.craft.ymlsetsminVersion: 3.0.0.- The
Prepare releasestep in.github/workflows/release.ymlinvokesgetsentry/craftat the pinned 2.34.1 commit. - That pinned version is below the configured minimum, so the release step fails minimum-version validation.
Identified by Warden · code-review · Y8H-8SX
|
@ric-oliv I think this one can be closed in favour of #5775. Craft 3.0.0 shipped on 2026-10-22 with getsentry/craft#686 in it, and #5775 makes both changes this PR was waiting to make: Any objection to closing this one? |
|
Sounds good! Closed! |
Follow-up to #5753. Burak suggested bumping
minVersionin his review there, and this does that.#5753 turned on the nuget target's
workspacesmode from getsentry/craft#686. A craft version without #686 doesn't know these keys. It ignores them and publishes every package through a singlenugettarget with--skip-duplicate, and the release still succeeds. So if an older craft ever runs our release, nothing tells us it took the old path.This sets
minVersionto 3.0.0. #686 is afeat(nuget)!:change, and craft's auto versioning turns a!title into a major bump. The Semver Impact check on #686 says Major too. So the release that ships it should be 3.0.0, and an older craft now stops with a config error instead of quietly publishing the old way.The bump doesn't change anything else craft does for us. Craft gates a few defaults on
minVersion. Auto versioning (2.14.0) and automatic version bumping (2.21.0) were already on at 2.26.3. The only new gate this crosses is 2.29.0, which is for the top-levelworkspaceskey, and we don't use that one.Blocked until craft 3.0.0 is out
Craft hasn't released #686 yet. The latest release is 2.35.1, and our
release.ymlstill pins 2.34.1. With this change alone,craft preparewould fail the version check. So this stays a draft until craft cuts the release. Then I'll:getsentry/craftinrelease.ymlto the 3.0.0 release commitminVersionhere if the release ends up with a different numberWhat I checked
Incompatible "craft" versions. Current version: 2.35.1 (0ff7589...), minimal version: 3.0.0 (taken from .craft.yml).master, which has Fix NLog failing tests #686, with its version set to 3.0.0 and rancraft targetson this branch without submodules. It accepts the config and lists 23nuget[...]targets plusgithubandregistry. That's the 22 from ci(craft): publish each NuGet package as its own craft target #5753 plusSentry.Quartz, which landed on main since then and which the filters already pick up.#skip-changelog