Repository navigation
fix(maui): CreateElementEventsBreadcrumbs set in code is no longer overwritten - #5861
Merged
Merged
Conversation
…erwritten BindableSentryMauiOptions.CreateElementEventsBreadcrumbs was initialised to false, so ApplyTo reset the value whenever the key was absent from configuration, clobbering anything set in the UseSentry delegate. Fixes #5859 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5861 +/- ##
==========================================
- Coverage 76.69% 76.68% -0.02%
==========================================
Files 528 528
Lines 19527 19527
Branches 3840 3840
==========================================
- Hits 14976 14974 -2
- Misses 3667 3669 +2
Partials 884 884 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ric-oliv
reviewed
Nov 3, 2026
On version7 the config binding already runs before the UseSentry callback, so the previous test would stop guarding the fix once main is merged there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 10, 2026
This was referenced Nov 12, 2026
This was referenced Nov 16, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BindableSentryMauiOptions.CreateElementEventsBreadcrumbswas initialised tofalserather thannull. SinceApplyTouses?? options.CreateElementEventsBreadcrumbs, the configuration pass (which runs after the user'sUseSentrydelegate) always wrotefalseunlessSentry:CreateElementEventsBreadcrumbswas present in configuration, so enabling it in code had no effect.Dropping the initialiser makes it match every other bindable property. Added a regression test that fails without the fix.
Closes #5859
🤖 Generated with Claude Code