Skip to content

fix(maui): CreateElementEventsBreadcrumbs set in code is no longer overwritten - #5861

Merged
jamescrosswell merged 2 commits into
mainfrom
ai/sentry-dotnet-5859-913304
Nov 3, 2026
Merged

jamescrosswell merged 2 commits into
mainfrom
ai/sentry-dotnet-5859-913304

Conversation

@jamescrosswell

Copy link
Copy Markdown
Collaborator

BindableSentryMauiOptions.CreateElementEventsBreadcrumbs was initialised to false rather than null. Since ApplyTo uses ?? options.CreateElementEventsBreadcrumbs, the configuration pass (which runs after the user's UseSentry delegate) always wrote false unless Sentry:CreateElementEventsBreadcrumbs was present in configuration, so enabling it in code had no effect.

Dropping the initialiser makes it match every other bindable property. Added a regression test that fails without the fix.

Closes #5859

🤖 Generated with Claude Code

…erwritten

BindableSentryMauiOptions.CreateElementEventsBreadcrumbs was initialised
to false, so ApplyTo reset the value whenever the key was absent from
configuration, clobbering anything set in the UseSentry delegate.

Fixes #5859

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.68%. Comparing base (193656c) to head (5f58ffe).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5861      +/-   ##
==========================================
- Coverage   76.69%   76.68%   -0.02%     
==========================================
  Files         528      528              
  Lines       19527    19527              
  Branches     3840     3840              
==========================================
- Hits        14976    14974       -2     
- Misses       3667     3669       +2     
  Partials      884      884              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jamescrosswell
jamescrosswell marked this pull request as ready for review November 3, 2026 04:13
@github-actions github-actions Bot added the risk: medium PR risk score: medium label Nov 3, 2026
On version7 the config binding already runs before the UseSentry callback,
so the previous test would stop guarding the fix once main is merged there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@ric-oliv ric-oliv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jamescrosswell
jamescrosswell merged commit f1a29b1 into main Nov 3, 2026
58 checks passed
@jamescrosswell
jamescrosswell deleted the ai/sentry-dotnet-5859-913304 branch November 3, 2026 21:22
This was referenced Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: medium PR risk score: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MAUI: CreateElementEventsBreadcrumbs set in code is overwritten with false

2 participants