Skip to content

ci(craft): Give every registry entry the metadata craft needs for new packages - #6236

Merged
markushi merged 5 commits into
mainfrom
fix/release-registry
Oct 8, 2026
Merged

markushi merged 5 commits into
mainfrom
fix/release-registry

Conversation

@markushi

@markushi markushi commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

📜 Description

Extend all packages within .craft.yml to carry name, packageUrl, mainDocsUrl and apiDocsUrl.
Craft will use that for information for new artifacts being pushed to the release registry. Verified the changes against the release registry packages/maven/io.sentry/*/latest.json.

Changes on top:

  • packageUrl is normalised to https://central.sonatype.com/artifact/io.sentry/<artifact>
  • apiDocsUrl is normalised to https://javadoc.io/doc/io.sentry
  • The docs URLs were corrected too and a few 404 links fixed

💡 Motivation and Context

8.60.0 published to Maven Central and cut the GitHub release, then craft aborted on the registry target (run 37632424636):

[error] "name" is required for new package "maven:io.sentry:sentry-android-navigation3".
        Add `name` to the registry target config in your .craft.yml.

Craft only reads name/packageUrl/mainDocsUrl for a package it has not published before — for anything already in sentry-release-registry it carries the existing manifest forward, so a bare maven:io.sentry:<artifact>: key works fine. The catch is that it keeps working right up until the release that first ships a new artifact, and then fails the entire registry target rather than just that one entry.

Same approach as getsentry/sentry-dotnet#5496

💚 How did you test it?

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.

🔮 Next steps

#skip-changelog

@sentry

sentry Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.59.0 (1) release

⚙️ sentry-android Build Distribution Settings

@markushi
markushi marked this pull request as ready for review October 8, 2026 10:06

@0xadam-brown 0xadam-brown left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

A comment inline if you want it, but no blockers.

More generally, I always worry clanker prose will pile up and be an unholy pain to undo at some point. Might be worth having your LLM take another pass using Simplified Technical English (ASD-STE100) and seeing if you get better results. But up to you and to whether you think it's worthwhile... 🤖

Comment thread .cursor/rules/new_module.mdc Outdated
@markushi
markushi enabled auto-merge (squash) October 8, 2026 11:24
@markushi
markushi merged commit a38fb2d into main Oct 8, 2026
71 checks passed
@markushi
markushi deleted the fix/release-registry branch October 8, 2026 11:39
markushi added a commit that referenced this pull request Oct 8, 2026
… packages (#6236) (#6237)

* ci(craft): Give every registry entry the metadata craft needs for new packages

* Refine comment

* docs(agents): Document the pre-publish requirements for new modules

* docs(rules): Correct the new-module rule and its publishing gate

* Simplify rules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants