Repository navigation
ci(craft): Give every registry entry the metadata craft needs for new packages - #6236
Merged
Merged
Conversation
📲 Install BuildsAndroid
|
markushi
marked this pull request as ready for review
October 8, 2026 10:06
markushi
requested review from
0xadam-brown,
adinauer,
romtsn and
runningcode
as code owners
October 8, 2026 10:06
0xadam-brown
approved these changes
Oct 8, 2026
0xadam-brown
left a comment
Member
There was a problem hiding this comment.
Thanks for the update!
A comment inline if you want it, but no blockers.
More generally, I always worry clanker prose will pile up and be an unholy pain to undo at some point. Might be worth having your LLM take another pass using Simplified Technical English (ASD-STE100) and seeing if you get better results. But up to you and to whether you think it's worthwhile... 🤖
markushi
enabled auto-merge (squash)
October 8, 2026 11:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Extend all packages within
.craft.ymlto carryname,packageUrl,mainDocsUrlandapiDocsUrl.Craft will use that for information for new artifacts being pushed to the release registry. Verified the changes against the release registry
packages/maven/io.sentry/*/latest.json.Changes on top:
packageUrlis normalised tohttps://central.sonatype.com/artifact/io.sentry/<artifact>apiDocsUrlis normalised tohttps://javadoc.io/doc/io.sentry💡 Motivation and Context
8.60.0 published to Maven Central and cut the GitHub release, then craft aborted on the
registrytarget (run 37632424636):Craft only reads
name/packageUrl/mainDocsUrlfor a package it has not published before — for anything already in sentry-release-registry it carries the existing manifest forward, so a baremaven:io.sentry:<artifact>:key works fine. The catch is that it keeps working right up until the release that first ships a new artifact, and then fails the entire registry target rather than just that one entry.Same approach as getsentry/sentry-dotnet#5496
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
#skip-changelog