ui.vue application render is always cancelled

Is there an existing issue for this?

I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
I have reviewed the documentation https://docs.sentry.io/
I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Self-hosted/on-premise

Which package are you using?

@sentry/vue

SDK Version

7.7.0

Framework Version

Link to Sentry event

No response

Steps to Reproduce

All application render is cancelled.

in the file node_modules\@sentry\vue\esm\tracing.js， i find that all const are replaced by var after building.

but var does not have block scope， which may cause some problems like this:

let mixins = [];
for(var i of [0, 1, 2]){
    mixins[i] = ()=> console.log(i);
}
mixins.forEach(func=>func())
// unexpected result：2 2 2

mixins = [];
for(const i of [0, 1, 2]){
    mixins[i] = ()=> console.log(i);
}
mixins.forEach(func=>func())
// expected result：0 1 2

span does not finish because highlight part code never work。

Solution：

use let to declare variables， to avoid to be replaced;
adjust rollup build config sentry-javascript\rollup\plugins\npmPlugins.js makeConstToVarPlugin()

Expected Result

ui.vue span can finish correctly

Actual Result

ui.vue span work in wrong way

Thanks for writing in! The conversion from const to var is indeed a bit dangerous and we'll discuss internally if we're going to keep it.

As for the span being cancelled, we're not sure if the issues are related because in theory the spans should enter the code branch you marked red, otherwise we would never even start a span.

We started working on #5693 anyways so a fix for that might actually resolve this issue too.

Update: Our investigation today revealed that the const->var conversion is also responsible for child component spans not being tracked in Vue 2 apps: #5925

@jinhao-c

@jinhao-c Hi, we removed the const-to-var transformation and released the change in version 7.16.0 of the SDK. Would you mind trying out the new version and reporting back whether it fixed the issue for you?

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

build(deps-dev): bump axios from 1.1.2 to 1.6.0 in /packages/e2e-test…

build(deps): bump axios from 1.3.4 to 1.6.0 in /packages/browser-inte…

Navigation Menu

Repository navigation

ui.vue application render is always cancelled #5917

Is there an existing issue for this?

How do you use Sentry?

Which package are you using?

SDK Version

Framework Version

Link to Sentry event

Steps to Reproduce

Expected Result

Actual Result

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

ui.vue application render is always cancelled #5917

Description

Is there an existing issue for this?

How do you use Sentry?

Which package are you using?

SDK Version

Framework Version

Link to Sentry event

Steps to Reproduce

Expected Result

Actual Result

Activity

lforst commented on Oct 10, 2022

Lms24 commented on Oct 17, 2022

lforst commented on Oct 19, 2022

github-actions commented on Nov 10, 2022

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions