Not compatible with Angular 2 AoT (Ahead-of-time compilation) #787

Activity

1. benvinegar commented on Dec 2, 2016

   

   benvinegar

   on Dec 2, 2016

   Contributor

   More actions

   To clarify, your suggestion is put it back the way it was (before 05ebd0)? Or should we have a proper ES2015 module export file for that platform somewhere?

   Basically, we're struggling with the TypeScript definition file. I basically kept tweaking things until I could get it loading in every possible loader. But it's becoming harder and harder to keep up with all of this. If someone from the Angular or TypeScript community could give us a definitive best practice for how the typings file should work, we'd be glad to make the requisite changes.
2. adrienverge commented on Dec 3, 2016

   

   adrienverge

   on Dec 3, 2016

   Author

   More actions

   Hi @benvinegar, thanks for your answer.

   I've spent a lot of time on this and I now see two points here:

   1. Should SystemJS be used to load raven-js bundle?

   First, as copied from here, raven-js is a third party global resource. The Raven object lives on window in the browser. Therefore it is maybe not correct to import it in an Angular 2 application.

   So I'm wondering whether it's correct or not to load it from SystemJS using System.config({ packages: { 'raven-js': { main: 'dist/raven.js' } } ...; maybe the best way is to import it through <script src="/node_modules/raven-js/dist/raven.min.js"></script> in the HTML file, leave systemjs.config.js alone, and let good old typings do the job at compilation time.

   What do you think? @Chuckv01 @NoNameProvided @davorpeic

   2. Typings shipped with raven-js

   I really don't think import Raven = require('raven-js'); is the "normal" way to import a bundled JS library. Most libs I've seen define modules in their declaration files, so they can be imported in many fashions (including import Raven from 'raven-js';).

   I'm working on a rewriting of the .d.ts file, I'd be happy to make a pull-request depending on the output of this dicussion. It would look like:

   declare module "raven-js" {
       export default ravenjs;
   }
   
   declare module ravenjs {
       interface RavenStatic { ... }
       interface RavenOptions { ... }
       ...
   }
   
   declare var Raven: ravenjs.RavenStatic;
3. NoNameProvided commented on Mar 1, 2017

   

   NoNameProvided

   on Mar 1, 2017

   More actions

   Just a heads up, it's compatible now, so the issue can be closed.
4. benvinegar commented on Mar 2, 2017

   

   benvinegar

   on Mar 2, 2017

   Contributor

   More actions

   Sweet.
5. benvinegar

   closed this as completedon Mar 2, 2017
6. pull

   added a commit that references this issue on Jun 19, 2026

   meta: Add changelog entry for 4.1.0 (getsentry#787)

   ...

   bab871b
7. logaretm

   added a commit that references this issue on Oct 5, 2026

   chore(deps): Bump web-vitals to 6.2.3 (#25062)

   ...

   21ba35d