Repository navigation
ref(remix): Make @remix-run/router a dependency. - #10479
Merged
Merged
Conversation
Contributor
size-limit report 📦
|
onurtemizkan
force-pushed
the
onur/remix-router-as-dependency
branch
6 times, most recently
from
February 5, 2024 17:31
450ace8 to
34733f0
Compare
Contributor
|
Is this ready to merge? |
onurtemizkan
force-pushed
the
onur/remix-router-as-dependency
branch
4 times, most recently
from
February 16, 2024 15:26
746f2ea to
4e3837e
Compare
onurtemizkan
marked this pull request as ready for review
February 16, 2024 15:30
Contributor
Author
|
@AbhiPrasad, I think this is ready to go now. |
AbhiPrasad
approved these changes
Feb 20, 2024
Contributor
|
Let's fix the merge conflicts and we can merge it in! Needs to probably be backported onto v7 as well. |
onurtemizkan
force-pushed
the
onur/remix-router-as-dependency
branch
from
February 21, 2024 18:42
4e3837e to
2e685a2
Compare
Contributor
|
@onurtemizkan mind cherry picking this and opening another PR against v7 branch? we should backport this release. |
AbhiPrasad
pushed a commit
that referenced
this pull request
Feb 21, 2024
Backports #10479 to v7 branch Original PR Description: > Fixes: #10349 > Related: #5860 > Related: #10458 > > Removes dynamic loading of `react-router-dom` and makes `@remix-run/router` a peer dependency. > > We don't need to dynamically load `react-router-dom` as our TypeScript version is now up-to-date.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #10349
Related: #5860
Related: #10458
Removes dynamic loading of
react-router-domand makes@remix-run/routera peer dependency.We don't need to dynamically load
react-router-domas our TypeScript version is now up-to-date.