Skip to content

test(e2e): Move react-router-8-cloudflare MySQL tests into react-router-8-framework - #24599

Draft
JPeer264 wants to merge 3 commits into
jp/e2e-runtime-variants-pocfrom
jp/react-router-8-cloudflare-into-framework
Draft

JPeer264 wants to merge 3 commits into
jp/e2e-runtime-variants-pocfrom
jp/react-router-8-cloudflare-into-framework

Conversation

@JPeer264

@JPeer264 JPeer264 commented Sep 22, 2026 •

Copy link
Copy Markdown
Member

With the Cloudflare variant of react-router-8-framework, the separate react-router-8-cloudflare app only added its MySQL test. This moves the MySQL route and both tests into react-router-8-framework and removes the old app, so one app covers React Router on Node, Deno and Cloudflare.

The MySQL tests now run on every variant, not only on Cloudflare. The Worker is wrapped by sentryCloudflareVitePlugin instead of a manual withSentry call; other Cloudflare apps still cover manual withSentry.

🤖 Generated with Claude Code

@JPeer264
JPeer264 added this pull request to stack #24600 September 22, 2026 16:42
@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 29.24 kB - -
@sentry/browser - with treeshaking flags 27.5 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 27.4 kB - -
@sentry/browser (incl. Tracing) 51.15 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 51.17 kB - -
@sentry/browser (incl. Tracing, Profiling) 54.18 kB - -
@sentry/browser (incl. Tracing, Replay) 90.76 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 79.86 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 95.46 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 108.41 kB - -
@sentry/browser (incl. Feedback) 46.76 kB - -
@sentry/browser (incl. sendFeedback) 34.3 kB - -
@sentry/browser (incl. FeedbackAsync) 39.41 kB - -
@sentry/browser (incl. Metrics) 30.25 kB - -
@sentry/browser (incl. Logs) 30.51 kB - -
@sentry/browser (incl. Metrics & Logs) 31.18 kB - -
@sentry/react 31.08 kB - -
@sentry/react (incl. Tracing) 53.54 kB - -
@sentry/vue 36.74 kB - -
@sentry/vue (incl. Tracing) 53.7 kB - -
@sentry/svelte 29.26 kB - -
CDN Bundle 31.02 kB - -
CDN Bundle (incl. Tracing) 51.77 kB - -
CDN Bundle (incl. Logs, Metrics) 33.29 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 53.75 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 74 kB - -
CDN Bundle (incl. Tracing, Replay) 89.36 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 91.33 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 95.53 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 97.5 kB - -
CDN Bundle - uncompressed 91.66 kB - -
CDN Bundle (incl. Tracing) - uncompressed 154.03 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 98.23 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 159.99 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 227.8 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 273.76 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 279.7 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 287.46 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 293.39 kB - -
@sentry/nextjs (client) 55.78 kB - -
@sentry/sveltekit (client) 51.59 kB - -
@sentry/core/server 39.99 kB - -
@sentry/core/browser 13.63 kB - -
@sentry/node 141.89 kB +0.02% +15 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 82.88 kB - -
@sentry/node - without tracing 90.9 kB +0.02% +15 B 🔺
@sentry/node - without channel injection 120.26 kB +0.01% +10 B 🔺
@sentry/aws-serverless 99.14 kB +0.01% +5 B 🔺
@sentry/cloudflare (withSentry) - minified 206.62 kB - -
@sentry/cloudflare (withSentry) 514.02 kB - -

View base workflow run

@JPeer264
JPeer264 force-pushed the jp/react-router-8-cloudflare-into-framework branch from 13b24d7 to aa5e441 Compare September 23, 2026 05:27
@JPeer264
JPeer264 force-pushed the jp/react-router-8-cloudflare-into-framework branch from aa5e441 to 5638fe5 Compare September 23, 2026 07:57
@JPeer264
JPeer264 force-pushed the jp/react-router-8-cloudflare-into-framework branch from 5638fe5 to 1289b2e Compare September 23, 2026 09:12
@JPeer264
JPeer264 removed this pull request from stack #24600 September 23, 2026 09:14
@JPeer264
JPeer264 added this pull request to stack #24613 September 23, 2026 09:15
@JPeer264
JPeer264 removed this pull request from stack #24613 September 23, 2026 09:51
@JPeer264
JPeer264 added this pull request to stack #24633 September 23, 2026 09:51
@JPeer264
JPeer264 force-pushed the jp/react-router-8-cloudflare-into-framework branch from 1289b2e to 8128af7 Compare September 23, 2026 10:04
@JPeer264
JPeer264 force-pushed the jp/react-router-8-cloudflare-into-framework branch from 8128af7 to cbc7810 Compare September 23, 2026 12:25
@JPeer264
JPeer264 force-pushed the jp/react-router-8-cloudflare-into-framework branch 2 times, most recently from fc013ea to d067bb5 Compare September 23, 2026 13:31
@JPeer264
JPeer264 force-pushed the jp/react-router-8-cloudflare-into-framework branch from d067bb5 to a8dfce1 Compare September 23, 2026 16:19
@JPeer264
JPeer264 removed this pull request from stack #24633 September 23, 2026 16:19
@JPeer264
JPeer264 added this pull request to stack #24670 September 23, 2026 16:19
@JPeer264
JPeer264 force-pushed the jp/react-router-8-cloudflare-into-framework branch from a8dfce1 to b8b902f Compare September 23, 2026 16:40
@JPeer264
JPeer264 force-pushed the jp/react-router-8-cloudflare-into-framework branch from b55e889 to cb692c3 Compare September 24, 2026 14:19
@JPeer264
JPeer264 force-pushed the jp/react-router-8-cloudflare-into-framework branch 2 times, most recently from 7739767 to b91a8ac Compare September 25, 2026 15:31
@JPeer264
JPeer264 force-pushed the jp/react-router-8-cloudflare-into-framework branch from b91a8ac to 29eab42 Compare September 25, 2026 15:41
@JPeer264
JPeer264 force-pushed the jp/react-router-8-cloudflare-into-framework branch 3 times, most recently from dc84aab to 11257ca Compare September 27, 2026 13:47
@JPeer264
JPeer264 force-pushed the jp/react-router-8-cloudflare-into-framework branch 2 times, most recently from 82884ff to fb18e31 Compare September 27, 2026 14:57
@JPeer264
JPeer264 force-pushed the jp/react-router-8-cloudflare-into-framework branch 2 times, most recently from 6323645 to e3b7e76 Compare September 28, 2026 08:07
@JPeer264
JPeer264 force-pushed the jp/react-router-8-cloudflare-into-framework branch 3 times, most recently from 910920b to 7479e87 Compare September 28, 2026 09:38
@JPeer264
JPeer264 force-pushed the jp/react-router-8-cloudflare-into-framework branch 3 times, most recently from e781deb to 933683f Compare September 28, 2026 14:29
JPeer264 and others added 3 commits September 29, 2026 08:22
Under `bun run` the SDK cannot inject the diagnostics channels into
libraries (JS-3508), so Bun apps must be built with `@sentry/bun/plugin`
to get framework, database and AI spans. The new `node-suites-bun-build`
project tests that path: the runner builds each scenario with the plugin
right before it starts (`RUNTIME_BUILD_SCRIPT`), and runs the bundle
with `@sentry/bun`.

The Docker suites run as well, so the Bun CI job gets the disk space
step of the Node and Deno jobs. `pg-native` and the CommonJS
`postgresjs` tests are skipped on Bun: the `libpq` addon needs a Node
symbol that Bun does not have, and through the `bun` export condition
`require('postgres')` returns the ES module namespace.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…amework

Runs the same Playwright suite on Bun, Deno and Cloudflare (local workerd)
as optional variants of the existing app, instead of one app per runtime.
A variant can set a `runtime` matrix key (`bun` or `deno`), and CI then
installs that runtime for the job. The Cloudflare build uses its own Vite
config with `@cloudflare/vite-plugin` and `sentryCloudflareVitePlugin`,
and swaps in a workerd server entry with the new `runtimeEntryPlugin`
from `@sentry-internal/test-utils/vite`.

The Cloudflare variant needed these SDK fixes:

- react-router: resolve the Cloudflare entry under the `workerd`
  condition, so `Sentry.flush` and `Sentry.startSpan` exist in a Worker.
- react-router: export `lowQualityTransactionsFilterIntegration` from
  `/cloudflare`.
- react-router: do not write trace meta tags into prerendered pages on
  Cloudflare, which otherwise pinned every visitor of the static page to
  one build-time trace.

Under `bun run` Express is not instrumented, so on Bun the error
transaction stays the request path. On Cloudflare the error has no
transaction. On both, the meta tag names the http.server segment. The Bun
variant relies on the diagnostics channel fixes of the Bun
auto-instrumentation suites PR it is based on.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…er-8-framework

The Cloudflare variant of react-router-8-framework now covers what the
separate react-router-8-cloudflare app tested, so the MySQL route and tests
move over and the old app is removed. The tests now also run on Node, Bun
and Deno. The Worker is wrapped by `sentryCloudflareVitePlugin` instead of a
manual `withSentry` call.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@JPeer264
JPeer264 force-pushed the jp/react-router-8-cloudflare-into-framework branch from 933683f to 492d9ef Compare September 29, 2026 06:25

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant