fix(nextjs): Limit Turbopack orchestrion loader to instrumented packages - #24792
Merged
Merged
Conversation
Turbopack runs webpack loaders out of process, one round trip per matched file. The orchestrion rule matched every server-side JS module, including all of node_modules, so large apps paid that cost for files the transform never touches. Restrict the rule with a path condition built from the instrumented package names. Fixes #24764 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Member
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit e2ac19f. Configure here.
Contributor
size-limit report 📦
|
chargome
marked this pull request as ready for review
September 28, 2026 10:38
chargome
requested review from
nicohrubec and
s1gr1d
and removed request for
a team
September 28, 2026 10:39
JPeer264
approved these changes
Sep 28, 2026
timfish
approved these changes
Sep 28, 2026
47 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turbopack runs webpack loaders in a separate process, once per matched file. Our orchestrion rule matched every server-side JS file, including all of
node_modules. Large apps paid that cost for files the transform never touches. The reporter's build went from 2 minutes to a 45 minute Vercel timeout after upgrading to v11, where build-time instrumentation is on by default.The rule now has a
pathcondition that only matches files inside instrumented packages. It matchesnode_modules/<name>/anywhere in the path, so hoisted, workspace, scoped and pnpm layouts all work. The loader already skipped every other file, so the set of transformed modules does not change. Next.js 16.0.0 already supports RegExppathconditions.The webpack path is unchanged. Webpack runs loaders in process, so the broad rule is cheap there.
Fixes #24764