Skip to content

test(pydantic-ai): Remove vacuous _set_model_data() tests - #7453

Merged
alexander-alderman-webb merged 1 commit into
masterfrom
webb/pydantic-ai/remove-set-model-data-tests
Sep 10, 2026
Merged

alexander-alderman-webb merged 1 commit into
masterfrom
webb/pydantic-ai/remove-set-model-data-tests

Conversation

@alexander-alderman-webb

Copy link
Copy Markdown
Contributor

Description

The assertions are trivial because a manual transaction is created, and we should not test private functions to begin with.

Issues

Reminders

@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner September 10, 2026 07:24
@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

131835 passed | ⏭️ 7131 skipped | Total: 138966 | Pass Rate: 94.87% | Execution Time: 471m 29s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -40
Passed Tests 📉 -40
Failed Tests
Skipped Tests

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2532 uncovered lines.
❌ Project coverage is 90.18%. Comparing base (48c48d2) to head (1fc103d).

Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.20%    90.18%    -0.02%
==========================================
  Files          193       193         —
  Lines        25788     25788         —
  Branches      9530      9530         —
==========================================
+ Hits         23261     23256        -5
- Misses        2527      2532        +5
- Partials      1432      1430        -2

Generated by Codecov Action

@alexander-alderman-webb
alexander-alderman-webb merged commit a618e3a into master Sep 10, 2026
310 of 312 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/pydantic-ai/remove-set-model-data-tests branch September 10, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants