Skip to content

critical: 2.10.2.windows.1: git-gui crashes when opening a 3rd window #1014

Closed

Description

@zosrothko
  • I was not able to find an open or closed issue matching what I'm seeing

Setup

  • Which version of Git for Windows are you using? Is it 32-bit or 64-bit?
$ git --version --build-options
Z:\git\javaccPlugin> git --version --build-options
git version 2.10.2.windows.1
sizeof-long: 4
machine: x86_64
  • Which version of Windows are you running? Vista, 7, 8, 10? Is it 32-bit or 64-bit?
$ cmd.exe /c ver
Z:\git\javaccPlugin>cmd.exe /c ver

Microsoft Windows [version 6.1.7601]
  • What options did you set as part of the installation? Or did you choose the
    defaults?
# One of the following:
Z:\git\javaccPlugin>type "C:\Program Files\Git\etc\install-options.txt"
Path Option: Cmd
SSH Option: OpenSSH
CRLF Option: CRLFAlways
Bash Terminal Option: ConHost
Performance Tweaks FSCache: Enabled
Enable Symlinks: Disabled

  • Any other interesting things about your environment that might be related
    to the issue you're seeing?

TODO

Details

  • Which terminal/shell are you running Git from? e.g Bash/CMD/PowerShell/other

cmd.exe

"C:\Program Files\Git\cmd\git-gui.exe", then Open Existing Repository, then Selecting a disk
 - What did you expect to occur after running these commands?

A new Git Gui window

 - What actually happened instead?
Git Gui is crashing

 - If the problem was occurring with a specific repository, can you provide the
   URL to that repository to help us with testing?
The panl Open Recent Repository contains a list of 10 repository

Activity

  1. dscho commented on Dec 31, 2016

    @dscho
    Member

    Git Gui is crashing

    Could you be more specific how it crashes (e.g. how can you tell that Git GUI is not simply refusing to do stuff because it does not find any associated repository)?

  2. zosrothko commented on Jan 1, 2017

    @zosrothko
    Author

    Your are right.. I do not know if it is really git-gui that crashes... but here the pop up window

    image

  3. zosrothko commented on Jan 13, 2017

    @zosrothko
    Author

    Update... the Wish application crashes when opening a new repository not in the list of open recent repositories and the list contains 10 repo.

  4. changed the title [-]2.10.2.windows.1: git-gui crashes when opening a 3rd window[/-] [+]critical: 2.10.2.windows.1: git-gui crashes when opening a 3rd window[/+] on Jan 13, 2017
  5. zosrothko commented on Jan 13, 2017

    @zosrothko
    Author

    This issue is critical since there is no way to flush the list....

  6. PhilipOakley commented on Jan 13, 2017

    @PhilipOakley

    look at my old series http://public-inbox.org/git/1450310287-4936-1-git-send-email-philipoakley@iee.org/

    I can't remember if this was merged.

  7. PhilipOakley commented on Jan 13, 2017

    @PhilipOakley

    @zosrothko, It looks like the series never got near the Git 'pu' branch. The series should also go to Pat Thoyts who maintains the git-gui https://github.com/git-for-windows/git/blob/master/Documentation/SubmittingPatches#L325-L327

    If you can review Junio's comments from the V2 series that would be a help. i.e. provide some feedback - this is open source, so your help is needed.

    Philip

  8. PhilipOakley commented on Jan 13, 2017

    @PhilipOakley

    Also, can you share the git-gui entries in your .gitconfig (just show the first ~5 chars of the path..).

    Try git config --global --show-origin -l in a bash terminal window to see all the settings (and where it is, $HOME)

    My gui section (from the above, without the --show-origin) looks like:

    gui.recentrepo=C:/Use.......
    gui.recentrepo=H:/IFS.....
    gui.recentrepo=N:/EO....
    gui.recentrepo=//De....
    gui.recentrepo=H:/Git...
    

    Do you have share (//) paths? Are the all absolute drive paths?

  9. dscho commented on Jan 13, 2017

    @dscho
    Member

    @zosrothko I agree with @PhilipOakley: your assistance is required to push the resolution forward.

  10. zosrothko commented on Jan 13, 2017

    @zosrothko
    Author

    Here the result:
    Z:\git\javacc>git config --global --show-origin -l
    file:C:/Users/FrancisANDRE/.gitconfig user.name=FrancisANDRE
    file:C:/Users/FrancisANDRE/.gitconfig user.email=zosrothko@orange.fr
    file:C:/Users/FrancisANDRE/.gitconfig gui.trustmtime=true
    file:C:/Users/FrancisANDRE/.gitconfig gui.warndetachedcommit=true
    file:C:/Users/FrancisANDRE/.gitconfig gui.tabsize=4
    file:C:/Users/FrancisANDRE/.gitconfig gui.recentrepo=Z:/git/asn1cpp
    file:C:/Users/FrancisANDRE/.gitconfig gui.recentrepo=Z:/git/poco
    file:C:/Users/FrancisANDRE/.gitconfig gui.recentrepo=Z:/git/poco-c++11
    file:C:/Users/FrancisANDRE/.gitconfig gui.recentrepo=Z:/git/gradle-mc
    file:C:/Users/FrancisANDRE/.gitconfig gui.recentrepo=Z:/git/poco-gradle
    file:C:/Users/FrancisANDRE/.gitconfig gui.recentrepo=Z:/git/gradle
    file:C:/Users/FrancisANDRE/.gitconfig gui.recentrepo=Z:/git/gradle-cppunit
    file:C:/Users/FrancisANDRE/.gitconfig gui.recentrepo=Z:/git/SPLC-JTB-JavaCC
    file:C:/Users/FrancisANDRE/.gitconfig gui.recentrepo=Z:/git/SPLC
    file:C:/Users/FrancisANDRE/.gitconfig gui.recentrepo=C:/MXW/MI/MI-4.1.0
    file:C:/Users/FrancisANDRE/.gitconfig filter.lfs.clean=git-lfs clean %f
    file:C:/Users/FrancisANDRE/.gitconfig filter.lfs.smudge=git-lfs smudge %f
    file:C:/Users/FrancisANDRE/.gitconfig filter.lfs.required=true
    file:C:/Users/FrancisANDRE/.gitconfig core.autocrlf=input
    file:C:/Users/FrancisANDRE/.gitconfig core.filemode=true
    file:C:/Users/FrancisANDRE/.gitconfig credential.helper=manager

  11. dscho commented on Jan 13, 2017

    @dscho
    Member

    Here the result:

    @zosrothko by "your assistance is required" I was more referring to offering a review of @PhilipOakley's patches, as well as actually testing whether they fix your issue.

  12. PhilipOakley commented on Jan 13, 2017

    @PhilipOakley

    @zosrothko Thanks for that output. It at least confirms that it isn't at all related to the \\server\path issue, and that you have exactly 10 entries at the moment, which appears to be blocking you.

    If you are able to pick up and apply those patches direct (*) to the Tcl/Tk shell script, and then check that they work for you that would be a great assistance as @dscho mentioned.

    (*) If you have the full git reo and SDK then all the better. Though as the gui is a simple shel script you could bypass all that by using a local tool to apply those diffs directly!

  13. PhilipOakley commented on Jan 13, 2017

    @PhilipOakley

    @zosrothko As a workaround, you can go to the text file file: C:/Users/FrancisANDRE/.gitconfig and edit that one to remove one of the gui recentrepo lines to at least get you working & helping again. 😉

  14. PhilipOakley commented on Jan 13, 2017

    @PhilipOakley

    The branch with my 4 patches is https://github.com/PhilipOakley/git/tree/dup-gui

    They are not the best (in retrospect) as they work through the fault/fix sequence of incremental improvement, rather than identifying and resolving all the issues as a clean sequence.

    Aside - @zosrothko - are all those repositories still in existance at those specific paths from your machine at the point that the gui is started?

  15. zosrothko commented on Jan 15, 2017

    @zosrothko
    Author

    I applied the 4 patches of @PhilipOakley and the issue is solved at least at first glance... Thanks for your help on this issue, but I think your patches should be applied to the main stream to avoid the same situation when moving to the 2.11 version. I let you close this issue or not if you want to keep it as a reminder.

  16. 131 remaining items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions