You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
critical: 2.10.2.windows.1: git-gui crashes when opening a 3rd window #1014
"C:\Program Files\Git\cmd\git-gui.exe", then Open Existing Repository, then Selecting a disk
- What did you expect to occur after running these commands?
A new Git Gui window
- What actually happened instead?
Git Gui is crashing
- If the problem was occurring with a specific repository, can you provide the
URL to that repository to help us with testing?
The panl Open Recent Repository contains a list of 10 repository
Could you be more specific how it crashes (e.g. how can you tell that Git GUI is not simply refusing to do stuff because it does not find any associated repository)?
changed the title [-]2.10.2.windows.1: git-gui crashes when opening a 3rd window[/-][+]critical: 2.10.2.windows.1: git-gui crashes when opening a 3rd window[/+]on Jan 13, 2017
@zosrothko by "your assistance is required" I was more referring to offering a review of @PhilipOakley's patches, as well as actually testing whether they fix your issue.
@zosrothko Thanks for that output. It at least confirms that it isn't at all related to the \\server\path issue, and that you have exactly 10 entries at the moment, which appears to be blocking you.
If you are able to pick up and apply those patches direct (*) to the Tcl/Tk shell script, and then check that they work for you that would be a great assistance as @dscho mentioned.
(*) If you have the full git reo and SDK then all the better. Though as the gui is a simple shel script you could bypass all that by using a local tool to apply those diffs directly!
@zosrothko As a workaround, you can go to the text file file: C:/Users/FrancisANDRE/.gitconfig and edit that one to remove one of the gui recentrepo lines to at least get you working & helping again. 😉
They are not the best (in retrospect) as they work through the fault/fix sequence of incremental improvement, rather than identifying and resolving all the issues as a clean sequence.
Aside - @zosrothko - are all those repositories still in existance at those specific paths from your machine at the point that the gui is started?
I applied the 4 patches of @PhilipOakley and the issue is solved at least at first glance... Thanks for your help on this issue, but I think your patches should be applied to the main stream to avoid the same situation when moving to the 2.11 version. I let you close this issue or not if you want to keep it as a reminder.
Activity
dscho commentedon Dec 31, 2016
Could you be more specific how it crashes (e.g. how can you tell that Git GUI is not simply refusing to do stuff because it does not find any associated repository)?
zosrothko commentedon Jan 1, 2017
Your are right.. I do not know if it is really git-gui that crashes... but here the pop up window
zosrothko commentedon Jan 13, 2017
Update... the Wish application crashes when opening a new repository not in the list of open recent repositories and the list contains 10 repo.
[-]2.10.2.windows.1: git-gui crashes when opening a 3rd window[/-][+]critical: 2.10.2.windows.1: git-gui crashes when opening a 3rd window[/+]zosrothko commentedon Jan 13, 2017
This issue is critical since there is no way to flush the list....
PhilipOakley commentedon Jan 13, 2017
look at my old series http://public-inbox.org/git/1450310287-4936-1-git-send-email-philipoakley@iee.org/
I can't remember if this was merged.
PhilipOakley commentedon Jan 13, 2017
@zosrothko, It looks like the series never got near the Git 'pu' branch. The series should also go to Pat Thoyts who maintains the git-gui https://github.com/git-for-windows/git/blob/master/Documentation/SubmittingPatches#L325-L327
If you can review Junio's comments from the V2 series that would be a help. i.e. provide some feedback - this is open source, so your help is needed.
Philip
PhilipOakley commentedon Jan 13, 2017
Also, can you share the git-gui entries in your .gitconfig (just show the first ~5 chars of the path..).
Try
git config --global --show-origin -lin a bash terminal window to see all the settings (and where it is, $HOME)My gui section (from the above, without the --show-origin) looks like:
Do you have share (//) paths? Are the all absolute drive paths?
dscho commentedon Jan 13, 2017
@zosrothko I agree with @PhilipOakley: your assistance is required to push the resolution forward.
zosrothko commentedon Jan 13, 2017
Here the result:
Z:\git\javacc>git config --global --show-origin -l
file:C:/Users/FrancisANDRE/.gitconfig user.name=FrancisANDRE
file:C:/Users/FrancisANDRE/.gitconfig user.email=zosrothko@orange.fr
file:C:/Users/FrancisANDRE/.gitconfig gui.trustmtime=true
file:C:/Users/FrancisANDRE/.gitconfig gui.warndetachedcommit=true
file:C:/Users/FrancisANDRE/.gitconfig gui.tabsize=4
file:C:/Users/FrancisANDRE/.gitconfig gui.recentrepo=Z:/git/asn1cpp
file:C:/Users/FrancisANDRE/.gitconfig gui.recentrepo=Z:/git/poco
file:C:/Users/FrancisANDRE/.gitconfig gui.recentrepo=Z:/git/poco-c++11
file:C:/Users/FrancisANDRE/.gitconfig gui.recentrepo=Z:/git/gradle-mc
file:C:/Users/FrancisANDRE/.gitconfig gui.recentrepo=Z:/git/poco-gradle
file:C:/Users/FrancisANDRE/.gitconfig gui.recentrepo=Z:/git/gradle
file:C:/Users/FrancisANDRE/.gitconfig gui.recentrepo=Z:/git/gradle-cppunit
file:C:/Users/FrancisANDRE/.gitconfig gui.recentrepo=Z:/git/SPLC-JTB-JavaCC
file:C:/Users/FrancisANDRE/.gitconfig gui.recentrepo=Z:/git/SPLC
file:C:/Users/FrancisANDRE/.gitconfig gui.recentrepo=C:/MXW/MI/MI-4.1.0
file:C:/Users/FrancisANDRE/.gitconfig filter.lfs.clean=git-lfs clean %f
file:C:/Users/FrancisANDRE/.gitconfig filter.lfs.smudge=git-lfs smudge %f
file:C:/Users/FrancisANDRE/.gitconfig filter.lfs.required=true
file:C:/Users/FrancisANDRE/.gitconfig core.autocrlf=input
file:C:/Users/FrancisANDRE/.gitconfig core.filemode=true
file:C:/Users/FrancisANDRE/.gitconfig credential.helper=manager
dscho commentedon Jan 13, 2017
@zosrothko by "your assistance is required" I was more referring to offering a review of @PhilipOakley's patches, as well as actually testing whether they fix your issue.
PhilipOakley commentedon Jan 13, 2017
@zosrothko Thanks for that output. It at least confirms that it isn't at all related to the
\\server\pathissue, and that you have exactly 10 entries at the moment, which appears to be blocking you.If you are able to pick up and apply those patches direct (*) to the Tcl/Tk shell script, and then check that they work for you that would be a great assistance as @dscho mentioned.
(*) If you have the full git reo and SDK then all the better. Though as the gui is a simple shel script you could bypass all that by using a local tool to apply those diffs directly!
PhilipOakley commentedon Jan 13, 2017
@zosrothko As a workaround, you can go to the text file file:
C:/Users/FrancisANDRE/.gitconfigand edit that one to remove one of the gui recentrepo lines to at least get you working & helping again. 😉PhilipOakley commentedon Jan 13, 2017
The branch with my 4 patches is https://github.com/PhilipOakley/git/tree/dup-gui
They are not the best (in retrospect) as they work through the fault/fix sequence of incremental improvement, rather than identifying and resolving all the issues as a clean sequence.
Aside - @zosrothko - are all those repositories still in existance at those specific paths from your machine at the point that the gui is started?
zosrothko commentedon Jan 15, 2017
I applied the 4 patches of @PhilipOakley and the issue is solved at least at first glance... Thanks for your help on this issue, but I think your patches should be applied to the main stream to avoid the same situation when moving to the 2.11 version. I let you close this issue or not if you want to keep it as a reminder.
131 remaining items
git-gui: remove duplicate entries from .gitconfig's gui.recentrepo
git-gui: remove duplicate entries from .gitconfig's gui.recentrepo
git-gui: remove duplicate entries from .gitconfig's gui.recentrepo
git-gui: remove duplicate entries from .gitconfig's gui.recentrepo
git-gui: remove duplicate entries from .gitconfig's gui.recentrepo
git-gui: remove duplicate entries from .gitconfig's gui.recentrepo
git-gui: remove duplicate entries from .gitconfig's gui.recentrepo
git-gui: remove duplicate entries from .gitconfig's gui.recentrepo
git-gui: remove duplicate entries from .gitconfig's gui.recentrepo
git-gui: remove duplicate entries from .gitconfig's gui.recentrepo
git-gui: remove duplicate entries from .gitconfig's gui.recentrepo
git-gui: remove duplicate entries from .gitconfig's gui.recentrepo
git-gui: remove duplicate entries from .gitconfig's gui.recentrepo
git-gui: remove duplicate entries from .gitconfig's gui.recentrepo