Repository navigation
Conversation
Add a feedback button on the center right so that users can leave feedback on the docs. - Vendor the code so that we're not including assets from a CDN. - Make sure it looks okay in dark mode and light mode by using a CSS variable. - The search bar was appearing above the feedback sidebar for some reason and it looked really bad, hack together a fix by setting a z-index. - Only include the feedback button on the docs pages. Instructions for how to upgrade the Push Feedback HTML/CSS in the future: npm install rm -rf static/js/pushfeedback/ mv node_modules/pushfeedback/dist/pushfeedback static/js Signed-off-by: Julia Evans <julia@jvns.ca>
Collaborator
Author
|
I emailed the Push Feedback creator for some clarifications and he was very helpful. Updated the PR description with answers to some of the questions I had (it's possible to remove the email/screenshot fields if we want, there are no cookies) I also asked if it's okay for us to host the JS/CSS code ourselves and they confirmed they don't make breaking API changes. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a feedback button on the center right so that users can leave feedback on the docs. Closes #2208. I wrote about the technical changes in the commit message. You can see a live version here: https://jvns.github.io/git-scm.com/docs/git-rebase
Here's what the feedback dashboard looks like. My idea right now is to mainly access the feedback through their website, to avoid creating too many email notifications. The idea is that instead of treating each feedback item as a separate issue to be addressed, instead we look for patterns in the feedback. So we'd wait until there are 10+ comments on a page and then improve it based on the patterns. This could also be used to prioritize which pages to improve, for example if there are pages with a lot of "thumbs down" type feedback.
Some issues I can think of:
hide_email. (documentation)pushfeedback_sessionid:"0yzl41voqmen". This doesn't seem like a privacy issue to me but wanted to flag it just in case.A bunch of screenshots of various things (light mode, dark mode, mobile, the feedback dialog)