Skip to content

One more fix related to TEST_GIT_INSTALLED - #111

Closed
dscho wants to merge 1 commit into
gitgitgadget:masterfrom
dscho:test-git-installed-extra
Closed

dscho wants to merge 1 commit into
gitgitgadget:masterfrom
dscho:test-git-installed-extra

Conversation

@dscho

@dscho dscho commented Jan 21, 2019

Copy link
Copy Markdown
Member

This fix should have gone into #73 (which was submitted as https://public-inbox.org/git/pull.73.v2.git.gitgitgadget@gmail.com and was integrated into master via 2488849 (Merge branch 'js/test-git-installed', 2018-11-19)). Ben Peart pointed out that I had forgotten to include it.

Cc: Ben Peart benpeart@microsoft.com

In 8abfdf4 (tests: explicitly use `git.exe` on Windows,
2018-11-14), we made sure to use the `.exe` file extension when
using an absolute path to `git.exe`, to avoid getting confused with a
file or directory in the same place that lacks said file extension.

For the same reason, we need to handle test-tool.exe the same way.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho

dscho commented Jan 21, 2019

Copy link
Copy Markdown
Member Author

/submit

@gitgitgadget

gitgitgadget Bot commented Jan 21, 2019

Copy link
Copy Markdown

Submitted as pull.111.git.gitgitgadget@gmail.com

@gitgitgadget

gitgitgadget Bot commented Jan 24, 2019

Copy link
Copy Markdown

This branch is now known as js/test-git-installed.

@gitgitgadget

gitgitgadget Bot commented Jan 24, 2019

Copy link
Copy Markdown

This patch series was integrated into pu via git@0ce5eae.

@gitgitgadget gitgitgadget Bot added the pu label Jan 24, 2019
Comment thread t/test-lib.sh Resolved
@gitgitgadget

gitgitgadget Bot commented Jan 28, 2019

Copy link
Copy Markdown

This patch series was integrated into pu via git@8d7a63f.

@gitgitgadget

gitgitgadget Bot commented Jan 29, 2019

Copy link
Copy Markdown

This patch series was integrated into pu via git@a6189fb.

@gitgitgadget

gitgitgadget Bot commented Jan 29, 2019

Copy link
Copy Markdown

This patch series was integrated into next via git@bab6eab.

@gitgitgadget gitgitgadget Bot added the next label Jan 29, 2019
@gitgitgadget

gitgitgadget Bot commented Feb 4, 2019

Copy link
Copy Markdown

This patch series was integrated into pu via git@6e0e613.

@gitgitgadget

gitgitgadget Bot commented Feb 5, 2019

Copy link
Copy Markdown

This patch series was integrated into pu via git@11494da.

@gitgitgadget

gitgitgadget Bot commented Feb 5, 2019

Copy link
Copy Markdown

This patch series was integrated into next via git@11494da.

@gitgitgadget

gitgitgadget Bot commented Feb 5, 2019

Copy link
Copy Markdown

This patch series was integrated into master via git@11494da.

@gitgitgadget gitgitgadget Bot added the master label Feb 5, 2019
@gitgitgadget gitgitgadget Bot closed this Feb 5, 2019
@gitgitgadget

gitgitgadget Bot commented Feb 5, 2019

Copy link
Copy Markdown

Closed via 11494da.

@dscho
dscho deleted the test-git-installed-extra branch February 6, 2019 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant