Skip to content

credential: do not mask the username - #138

Closed
dscho wants to merge 1 commit into
gitgitgadget:masterfrom
dscho:unmask-credentials-username
Closed

dscho wants to merge 1 commit into
gitgitgadget:masterfrom
dscho:unmask-credentials-username

Conversation

@dscho

@dscho dscho commented Feb 24, 2019 •

Copy link
Copy Markdown
Member

This is yet another patch that finally makes it from Git for Windows into core Git.

Changes since v1:

  • Fixed incorrect URL in the commit message.

Cc: Eric Sunshine sunshine@sunshineco.com

@dscho dscho mentioned this pull request Feb 25, 2019
35 tasks done
@dscho dscho added the ready to submit Has commits that have not been submitted yet label Feb 26, 2019
@dscho

dscho commented Apr 29, 2019

Copy link
Copy Markdown
Member Author

/submit

@dscho dscho removed the ready to submit Has commits that have not been submitted yet label Apr 29, 2019
@gitgitgadget

gitgitgadget Bot commented Apr 29, 2019

Copy link
Copy Markdown

Submitted as pull.138.git.gitgitgadget@gmail.com

Comment thread credential.c Resolved
When a user is asked for credentials there is no need to mask the
username, so the PROMPT_ASKPASS flag on calling credential_ask_one for
login is unnecessary.

The `credential_ask_one()` function internally uses `git_prompt()` which
in case it is given the flag PROMPT_ASKPASS uses masked input method
instead of git_terminal_prompt, which does not mask user input.

This fixes git-for-windows#675

Signed-off-by: Jarosław Honkis <yaras6@gmail.com>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho
dscho force-pushed the unmask-credentials-username branch from e459e48 to 344cbc3 Compare April 29, 2019 23:19
@dscho dscho added the ready to submit Has commits that have not been submitted yet label Apr 29, 2019
Comment thread credential.c Resolved
@dscho

dscho commented May 3, 2019

Copy link
Copy Markdown
Member Author

Dropping this patch, as per the consensus on the mailing list.

@dscho dscho closed this May 3, 2019
@dscho
dscho deleted the unmask-credentials-username branch May 3, 2019 09:08
@dscho dscho removed the ready to submit Has commits that have not been submitted yet label May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants