Skip to content

t5580: verify that alternates can be UNC paths - #140

Closed
dscho wants to merge 1 commit into
gitgitgadget:masterfrom
dscho:test-unc-alternates
Closed

dscho wants to merge 1 commit into
gitgitgadget:masterfrom
dscho:test-unc-alternates

Conversation

@dscho

@dscho dscho commented Feb 24, 2019

Copy link
Copy Markdown
Member

This was fixed in git.git's master some time ago, unfortunately not upstreamed from Git for Windows' patch thicket (my fault, or better put: the fault of the twenty-four hour days not being longer). We carried a regression test on top of the fix, and I can at least contribute that.

On Windows, UNC paths are a very convenient way to share data, and
alternates are all about sharing data.

We fixed a bug where alternates specifying UNC paths were not handled
properly, and it is high time that we add a regression test to ensure
that this bug is not reintroduced.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho dscho added the ready to submit Has commits that have not been submitted yet label Feb 24, 2019
@dscho

dscho commented Feb 25, 2019

Copy link
Copy Markdown
Member Author

/submit

@dscho dscho removed the ready to submit Has commits that have not been submitted yet label Feb 25, 2019
@gitgitgadget

gitgitgadget Bot commented Feb 25, 2019

Copy link
Copy Markdown

Submitted as pull.140.git.gitgitgadget@gmail.com

@dscho dscho mentioned this pull request Feb 25, 2019
35 tasks done
Comment thread t/t5580-clone-push-unc.sh Resolved
@gitgitgadget

gitgitgadget Bot commented May 7, 2019

Copy link
Copy Markdown

This branch is now known as js/t5580-unc-alternate-test.

@gitgitgadget

gitgitgadget Bot commented May 7, 2019

Copy link
Copy Markdown

This patch series was integrated into pu via git@f0c0adb.

@gitgitgadget gitgitgadget Bot added the pu label May 7, 2019
@gitgitgadget

gitgitgadget Bot commented May 8, 2019

Copy link
Copy Markdown

This patch series was integrated into pu via git@ae31419.

@gitgitgadget

gitgitgadget Bot commented May 8, 2019

Copy link
Copy Markdown

This patch series was integrated into pu via git@d616b47.

@gitgitgadget

gitgitgadget Bot commented May 9, 2019

Copy link
Copy Markdown

This patch series was integrated into pu via git@60839fe.

@gitgitgadget

gitgitgadget Bot commented May 10, 2019

Copy link
Copy Markdown

This patch series was integrated into pu via git@380c54e.

@gitgitgadget

gitgitgadget Bot commented May 13, 2019

Copy link
Copy Markdown

This patch series was integrated into pu via git@ddc59e9.

@gitgitgadget

gitgitgadget Bot commented May 13, 2019

Copy link
Copy Markdown

This patch series was integrated into pu via git@34a0e77.

@gitgitgadget

gitgitgadget Bot commented May 15, 2019

Copy link
Copy Markdown

This patch series was integrated into pu via git@6a538c1.

@gitgitgadget

gitgitgadget Bot commented May 15, 2019

Copy link
Copy Markdown

This patch series was integrated into next via git@dfff4a6.

@gitgitgadget gitgitgadget Bot added the next label May 15, 2019
@gitgitgadget

gitgitgadget Bot commented May 16, 2019

Copy link
Copy Markdown

This patch series was integrated into pu via git@0684276.

@gitgitgadget

gitgitgadget Bot commented May 19, 2019

Copy link
Copy Markdown

This patch series was integrated into pu via git@0b076b4.

@gitgitgadget

gitgitgadget Bot commented May 19, 2019

Copy link
Copy Markdown

This patch series was integrated into next via git@0b076b4.

@gitgitgadget

gitgitgadget Bot commented May 19, 2019

Copy link
Copy Markdown

This patch series was integrated into master via git@0b076b4.

@gitgitgadget gitgitgadget Bot added the master label May 19, 2019
@gitgitgadget

gitgitgadget Bot commented May 19, 2019

Copy link
Copy Markdown

Closed via 0b076b4.

@gitgitgadget gitgitgadget Bot closed this May 19, 2019
@dscho
dscho deleted the test-unc-alternates branch May 20, 2019 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant