Skip to content

Allow choosing the SSL backend cURL uses (plus related patches) - #46

Closed
dscho wants to merge 3 commits into
gitgitgadget:masterfrom
dscho:http-ssl-backend
Closed

dscho wants to merge 3 commits into
gitgitgadget:masterfrom
dscho:http-ssl-backend

Conversation

@dscho

@dscho dscho commented Oct 15, 2018 •

Copy link
Copy Markdown
Member

This topic branch brings support for choosing cURL's SSL backend (a feature developed in Git for Windows' context) at runtime via http.sslBackend, and two more patches that are related (and only of interest for Windows users).

Changes since v1:

  • Reworded the commit message of v1's patch 2/3, to talk about the original design instead of "an earlier iteration" that was never contributed to the Git mailing list.
  • Changed the confusing >= 7.44.0 to < 7.44.0.

Note: I had prepared dscho@81e8c9a, intended to be included in v2, but Junio came up with https://public-inbox.org/git/xmqqsh0uln5c.fsf_-_@gitster-ct.c.googlers.com/ in the meantime, which I like better.

@dscho dscho mentioned this pull request Oct 15, 2018
35 tasks done
@dscho

dscho commented Oct 15, 2018

Copy link
Copy Markdown
Member Author

/submit

@gitgitgadget

gitgitgadget Bot commented Oct 15, 2018

Copy link
Copy Markdown

Submitted as pull.46.git.gitgitgadget@gmail.com

dscho and others added 3 commits October 25, 2018 20:43
As of version 7.56.0, curl supports being compiled with multiple SSL
backends.

This patch adds the Git side of that feature: by setting http.sslBackend
to "openssl" or "schannel", Git for Windows can now choose the SSL
backend at runtime.

This comes in handy on Windows because Secure Channel ("schannel") is
the native solution, accessing the Windows Credential Store, thereby
allowing for enterprise-wide management of certificates. For historical
reasons, Git for Windows needs to support OpenSSL still, as it has
previously been the only supported SSL backend in Git for Windows for
almost a decade.

The patch has been carried in Git for Windows for over a year, and is
considered mature.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This adds support for a new http.schannelCheckRevoke config value.

This config value is only used if http.sslBackend is set to "schannel",
which forces cURL to use the Windows Certificate Store when validating
server certificates associated with a remote server.

This config value should only be set to "false" if you are in an
environment where revocation checks are blocked by the network, with
no alternative options.

This is only supported in cURL 7.44 or later.

Note: originally, we wanted to call the config setting
`http.schannel.checkRevoke`. This, however, does not work: the `http.*`
config settings can be limited to specific URLs via `http.<url>.*`
(and this feature would mistake `schannel` for a URL).

Helped by Agustín Martín Barbero.

Signed-off-by: Brendan Forster <github@brendanforster.com>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
As of cURL v7.60.0, the Secure Channel backend can use the certificate
bundle provided via `http.sslCAInfo`, but that would override the
Windows Certificate Store. Since this is not desirable by default, let's
tell Git to not ask cURL to use that bundle by default when the `schannel`
backend was configured via `http.sslBackend`, unless
`http.schannelUseSSLCAInfo` overrides this behavior.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho

dscho commented Oct 25, 2018

Copy link
Copy Markdown
Member Author

/submit

@gitgitgadget

gitgitgadget Bot commented Oct 25, 2018

Copy link
Copy Markdown

Submitted as pull.46.v2.git.gitgitgadget@gmail.com

dscho commented Nov 2, 2018

Copy link
Copy Markdown
Member Author

This branch is now known as js/mingw-http-ssl.

dscho commented Nov 2, 2018

Copy link
Copy Markdown
Member Author

This patch series was integrated into pu via git@b55c282.

dscho commented Nov 2, 2018

Copy link
Copy Markdown
Member Author

This patch series was integrated into next via git@318e82e.

This comment has been minimized.

dscho commented Nov 5, 2018

Copy link
Copy Markdown
Member Author

This patch series was integrated into pu via git@d7b1859.

dscho commented Nov 5, 2018

Copy link
Copy Markdown
Member Author

This patch series was integrated into next via git@d7b1859.

dscho commented Nov 5, 2018

Copy link
Copy Markdown
Member Author

This patch series was integrated into master via git@d7b1859.

@dscho dscho added the master label Nov 5, 2018 — with GitGitGadget
@dscho dscho closed this Nov 5, 2018

dscho commented Nov 5, 2018

Copy link
Copy Markdown
Member Author

Closed via d7b1859.

@dscho
dscho deleted the http-ssl-backend branch November 5, 2018 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants