Repository navigation
Conversation
35 tasks done
Member
Author
|
/submit |
|
Submitted as pull.46.git.gitgitgadget@gmail.com |
dscho
force-pushed
the
http-ssl-backend
branch
from
October 16, 2018 12:29
9927e4c to
41a3ea5
Compare
As of version 7.56.0, curl supports being compiled with multiple SSL
backends.
This patch adds the Git side of that feature: by setting http.sslBackend
to "openssl" or "schannel", Git for Windows can now choose the SSL
backend at runtime.
This comes in handy on Windows because Secure Channel ("schannel") is
the native solution, accessing the Windows Credential Store, thereby
allowing for enterprise-wide management of certificates. For historical
reasons, Git for Windows needs to support OpenSSL still, as it has
previously been the only supported SSL backend in Git for Windows for
almost a decade.
The patch has been carried in Git for Windows for over a year, and is
considered mature.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This adds support for a new http.schannelCheckRevoke config value. This config value is only used if http.sslBackend is set to "schannel", which forces cURL to use the Windows Certificate Store when validating server certificates associated with a remote server. This config value should only be set to "false" if you are in an environment where revocation checks are blocked by the network, with no alternative options. This is only supported in cURL 7.44 or later. Note: originally, we wanted to call the config setting `http.schannel.checkRevoke`. This, however, does not work: the `http.*` config settings can be limited to specific URLs via `http.<url>.*` (and this feature would mistake `schannel` for a URL). Helped by Agustín Martín Barbero. Signed-off-by: Brendan Forster <github@brendanforster.com> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
As of cURL v7.60.0, the Secure Channel backend can use the certificate bundle provided via `http.sslCAInfo`, but that would override the Windows Certificate Store. Since this is not desirable by default, let's tell Git to not ask cURL to use that bundle by default when the `schannel` backend was configured via `http.sslBackend`, unless `http.schannelUseSSLCAInfo` overrides this behavior. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
force-pushed
the
http-ssl-backend
branch
from
October 25, 2018 18:46
41a3ea5 to
a5f937a
Compare
Member
Author
|
/submit |
|
Submitted as pull.46.v2.git.gitgitgadget@gmail.com |
Member
Author
|
This branch is now known as |
Member
Author
|
This patch series was integrated into pu via git@b55c282. |
Member
Author
|
This patch series was integrated into next via git@318e82e. |
This comment has been minimized.
This comment has been minimized.
Member
Author
|
This patch series was integrated into pu via git@d7b1859. |
Member
Author
|
This patch series was integrated into next via git@d7b1859. |
Member
Author
|
This patch series was integrated into master via git@d7b1859. |
Member
Author
|
Closed via d7b1859. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This topic branch brings support for choosing cURL's SSL backend (a feature developed in Git for Windows' context) at runtime via
http.sslBackend, and two more patches that are related (and only of interest for Windows users).Changes since v1:
>= 7.44.0to< 7.44.0.Note: I had prepared dscho@81e8c9a, intended to be included in v2, but Junio came up with https://public-inbox.org/git/xmqqsh0uln5c.fsf_-_@gitster-ct.c.googlers.com/ in the meantime, which I like better.