Skip to content

Some left-over add-on for bw/config-h - #78

Closed
dscho wants to merge 1 commit into
gitgitgadget:masterfrom
dscho:bw/config-h
Closed

dscho wants to merge 1 commit into
gitgitgadget:masterfrom
dscho:bw/config-h

Conversation

@dscho

@dscho dscho commented Nov 13, 2018 •

Copy link
Copy Markdown
Member

Back when bw/config-h was developed (and backported to Git for Windows), I came up with a patch to use git_dir if commondir is NULL, and contributed that as v1 of this patch. However, it was deemed a bug if that happens, so let's instead detect that condition and report it.

Change since v1:

  • Be loud about this bug instead of papering over it.

@dscho dscho mentioned this pull request Nov 13, 2018
35 tasks done
@dscho

dscho commented Nov 13, 2018

Copy link
Copy Markdown
Member Author

/submit

@gitgitgadget

gitgitgadget Bot commented Nov 13, 2018

Copy link
Copy Markdown

Submitted as pull.78.git.gitgitgadget@gmail.com

This did happen at some stage, and was fixed relatively quickly. Make
sure that we detect very quickly, too, should that happen again.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho

dscho commented Nov 14, 2018

Copy link
Copy Markdown
Member Author

/submit

@gitgitgadget

gitgitgadget Bot commented Nov 14, 2018

Copy link
Copy Markdown

Submitted as pull.78.v2.git.gitgitgadget@gmail.com

@gitgitgadget

gitgitgadget Bot commented Dec 15, 2018

Copy link
Copy Markdown

This branch is now known as js/config-sequence.

@gitgitgadget

gitgitgadget Bot commented Dec 15, 2018

Copy link
Copy Markdown

This patch series was integrated into pu via git@744fad6.

@gitgitgadget

gitgitgadget Bot commented Dec 15, 2018

Copy link
Copy Markdown

This patch series was integrated into next via git@744fad6.

@gitgitgadget

gitgitgadget Bot commented Dec 15, 2018

Copy link
Copy Markdown

This patch series was integrated into master via git@744fad6.

@gitgitgadget

gitgitgadget Bot commented Dec 15, 2018

Copy link
Copy Markdown

This patch series was integrated into maint via git@744fad6.

@gitgitgadget

gitgitgadget Bot commented Dec 15, 2018

Copy link
Copy Markdown

Closed via 744fad6.

@gitgitgadget gitgitgadget Bot closed this Dec 15, 2018
@dscho
dscho deleted the bw/config-h branch December 15, 2018 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant