Skip to content

bundle: fix issue when bundles would be empty - #79

Closed
dscho wants to merge 1 commit into
gitgitgadget:masterfrom
dscho:create-empty-bundle
Closed

dscho wants to merge 1 commit into
gitgitgadget:masterfrom
dscho:create-empty-bundle

Conversation

@dscho

@dscho dscho commented Nov 13, 2018 •

Copy link
Copy Markdown
Member

And yet another patch coming through Git for Windows...

Change since v1:

  • Using a better oneline now.

Cc: Stefan Beller sbeller@google.com

@dscho dscho mentioned this pull request Nov 13, 2018
35 tasks done
@dscho

dscho commented Nov 13, 2018

Copy link
Copy Markdown
Member Author

/submit

@gitgitgadget

gitgitgadget Bot commented Nov 13, 2018

Copy link
Copy Markdown

Submitted as pull.79.git.gitgitgadget@gmail.com

When an user tries to create an empty bundle via `git bundle create
<bundle> <revlist>` where `<revlist>` resolves to an empty list (for
example, like `master..master`), the command fails and warns the user
about how it does not want to create empty bundle.

However, the `.lock` file was still open and on Windows that means
that it could not be deleted properly. This patch fixes that issue.

This closes git-for-windows#790

Signed-off-by: Gaël Lhez <gael.lhez@gmail.com>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho
dscho force-pushed the create-empty-bundle branch from 6276372 to c88887f Compare November 14, 2018 15:24
@dscho

dscho commented Nov 14, 2018

Copy link
Copy Markdown
Member Author

/submit

@gitgitgadget

gitgitgadget Bot commented Nov 14, 2018

Copy link
Copy Markdown

Submitted as pull.79.v2.git.gitgitgadget@gmail.com

@dscho

dscho commented Nov 21, 2018

Copy link
Copy Markdown
Member Author

@peff came up with a better fix that was merged in 9e3dc6b.

@dscho dscho closed this Nov 21, 2018
@dscho
dscho deleted the create-empty-bundle branch November 21, 2018 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants