Skip to content

gc/repack: release packs when needed - #95

Closed
dscho wants to merge 1 commit into
gitgitgadget:masterfrom
dscho:release-gc-repack
Closed

dscho wants to merge 1 commit into
gitgitgadget:masterfrom
dscho:release-gc-repack

Conversation

@dscho

@dscho dscho commented Dec 10, 2018

Copy link
Copy Markdown
Member

This fixes more "can't delete files while they are still open" issues on Windows.

On Windows, files cannot be removed nor renamed if there are still
handles held by a process. To remedy that, we introduced the
close_all_packs() function.

Earlier, we made sure that the packs are released just before `git gc`
is spawned, in case that gc wants to remove no-longer needed packs.

But this developer forgot that gc itself also needs to let go of packs,
e.g. when consolidating all packs via the --aggressive option.

Likewise, `git repack -d` wants to delete obsolete packs and therefore
needs to close all pack handles, too.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho dscho mentioned this pull request Dec 10, 2018
35 tasks done
@dscho

dscho commented Dec 15, 2018

Copy link
Copy Markdown
Member Author

/submit

@gitgitgadget

gitgitgadget Bot commented Dec 15, 2018

Copy link
Copy Markdown

Submitted as pull.95.git.gitgitgadget@gmail.com

@gitgitgadget

gitgitgadget Bot commented Jan 18, 2019

Copy link
Copy Markdown

This branch is now known as js/gc-repack-close-before-remove.

@gitgitgadget

gitgitgadget Bot commented Jan 18, 2019

Copy link
Copy Markdown

This patch series was integrated into pu via git@0e0ea14.

@gitgitgadget

gitgitgadget Bot commented Jan 18, 2019

Copy link
Copy Markdown

This patch series was integrated into next via git@9daedfe.

@gitgitgadget

gitgitgadget Bot commented Jan 18, 2019

Copy link
Copy Markdown

This patch series was integrated into pu via git@5104f8f.

@gitgitgadget

gitgitgadget Bot commented Jan 18, 2019

Copy link
Copy Markdown

This patch series was integrated into next via git@5104f8f.

@gitgitgadget

gitgitgadget Bot commented Jan 18, 2019

Copy link
Copy Markdown

This patch series was integrated into master via git@5104f8f.

@gitgitgadget gitgitgadget Bot added the master label Jan 18, 2019
@gitgitgadget gitgitgadget Bot closed this Jan 18, 2019
@gitgitgadget

gitgitgadget Bot commented Jan 18, 2019

Copy link
Copy Markdown

Closed via 5104f8f.

@dscho
dscho deleted the release-gc-repack branch January 19, 2019 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant