Skip to content

Enable streaming while respecting proxy settings #2600

Closed

Description

@NlightNFotis

This is for the followup work to what's done in #2599 so that we provide a longer term fix for the issue described in #2593.

In #2599 we opted to deactivate the path that was using streaming, but the longer term, more robust fix, is to use streaming while detecting and respecting proxy settings that the client has setup.

Activity

  1. aeisenberg commented on Nov 18, 2024

    @aeisenberg
    Contributor

    Two options:

    1. Correctly apply proxy settings when we do streaming
    2. If we detect a proxy, disable streaming

    Maybe 2 is a better option because proxies are only going to be set on self-hosted runners, which are more likely to cache the bundle. This means they would not get much benefit from streaming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions