Skip to content

Update license; remove redundant Go qlpack license. - #18699

Merged
smowton merged 3 commits into
mainfrom
smowton/admin/update-license
Feb 20, 2025
Merged

smowton merged 3 commits into
mainfrom
smowton/admin/update-license

Conversation

@smowton

@smowton smowton commented Feb 6, 2025

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings February 6, 2025 10:24
@smowton
smowton requested review from a team as code owners February 6, 2025 10:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

@github-actions github-actions Bot added the Go label Feb 6, 2025
owen-mc
owen-mc previously approved these changes Feb 6, 2025
@owen-mc
owen-mc dismissed their stale review February 6, 2025 11:00

Oh wait, the tests really did not like you removing the license

@smowton

smowton commented Feb 6, 2025

Copy link
Copy Markdown
Contributor Author

Had a go at fixing it

@owen-mc owen-mc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth getting someone who is more familiar with Bazel to have a look before merging?

@smowton
smowton merged commit fe34aa3 into main Feb 20, 2025
@smowton
smowton deleted the smowton/admin/update-license branch February 20, 2025 18:19

@0321kejs-cyberKX 0321kejs-cyberKX left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants