Repository navigation
Add basic test for hooks - #1179
Merged
timvaillancourt merged 2 commits intoOct 21, 2022
Merged
Conversation
timvaillancourt
force-pushed
the
logic-hooks-tests
branch
2 times, most recently
from
September 15, 2022 03:18
66464e2 to
e53bbce
Compare
timvaillancourt
force-pushed
the
logic-hooks-tests
branch
from
September 17, 2022 17:07
1761df2 to
50bf651
Compare
ghost
approved these changes
Oct 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a simple test for
go/logic/hooks.goIn the process I found that the
initHooks()func ofHooksExecutorhas a staticreturn niland no other logic, making it fairly useless.migrator.initiateHooksExecutor()was modified to remove the call toinitHooks(), making it unnecessary as well.HooksExecutoris now instantiated inNewMigratorto simplify the codeLastly,
executeHooks()andexecuteHook()(fromHooksExecutor) were updated to use anout io.Writerfor output to facilitate testingscript/cibuildreturns with no formatting errors, build errors or unit test errors.