Skip to content

Remove stale RELEASE_VERSION file - #1349

Merged
timvaillancourt merged 2 commits into
github:masterfrom
timvaillancourt:rm-RELEASE_VERSION-file
Dec 7, 2023
Merged

timvaillancourt merged 2 commits into
github:masterfrom
timvaillancourt:rm-RELEASE_VERSION-file

Conversation

@timvaillancourt

Copy link
Copy Markdown
Collaborator

A Pull Request should be associated with an Issue.

Resolves issue: #1348

Description

This PR removes the RELEASE_VERSION file as it is often stale and not really required. I feel it is better to remove this and add it back later if it's truly needed - for now it's just leading to confusion

In case this PR introduced Go code changes:

  • contributed code is using same conventions as original code
  • script/cibuild returns with no formatting errors, build errors or unit test errors.

Signed-off-by: Tim Vaillancourt <tvaillancourt@slack-corp.com>
@timvaillancourt timvaillancourt changed the title Remove stale RELEASE_VERSION file Remove stale RELEASE_VERSION file Dec 7, 2023
@timvaillancourt timvaillancourt linked an issue Dec 7, 2023 that may be closed by this pull request
@timvaillancourt
timvaillancourt marked this pull request as ready for review December 7, 2023 14:35
@timvaillancourt timvaillancourt added this to the v1.1.7 milestone Dec 7, 2023
@timvaillancourt
timvaillancourt requested review from a user, meiji163 and rashiq December 7, 2023 16:21
@timvaillancourt
timvaillancourt merged commit fa12f44 into github:master Dec 7, 2023
@timvaillancourt
timvaillancourt deleted the rm-RELEASE_VERSION-file branch December 7, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RELEASE_VERSION file is stale

2 participants