Repository navigation
Fix --version output - #1352
Merged
timvaillancourt merged 2 commits intoDec 11, 2023
Merged
Fix --version output#1352
--version output#1352Conversation
Signed-off-by: Tim Vaillancourt <tvaillancourt@slack-corp.com>
Signed-off-by: Tim Vaillancourt <tvaillancourt@slack-corp.com>
timvaillancourt
commented
Dec 11, 2023
| flag.PrintDefaults() | ||
| return | ||
| } | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
Let's always fallback to unversioned/unknown so that the starting gh-ost %+v logline later also gets this fallback instead of ""
meiji163
approved these changes
Dec 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a problem introduced in #1347 due to my forgetting to add newline character to
fmt.Printf(...)🤦Secondly, I've made an empty
GitCommitdisplay a bit more clearerBefore (notice no
\nchar)After: undefined
AppVersion+GitCommitAfter
tvaillancourt@tvailla-ltmxctu gh-ost % go build -o gh-ost -ldflags "-X main.AppVersion=1.1.6 -X main.GitCommit=$(git rev-parse HEAD)" ./go/cmd/gh-ost/main.go tvaillancourt@tvailla-ltmxctu gh-ost % ./gh-ost --version 1.1.6 (git commit: 5ebb95347e2002a5a959483f3e801cd3267e7e88) tvaillancourt@tvailla-ltmxctu gh-ost %script/cibuildreturns with no formatting errors, build errors or unit test errors.