Skip to content

fix: avoid applying data-md-button styles twice after the toolbar is moved #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kwy404 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: avoid applying data-md-button styles twice after the toolbar is moved #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,15 +348,19 @@ function unsetFocusManagement(toolbar: MarkdownToolbarElement) {
class MarkdownToolbarElement extends HTMLElement {
static observedAttributes = ['data-no-focus']

constructor() {
super()
this.addEventListener('keydown', keydown(applyFromToolbar))
this.addEventListener('click', applyFromToolbar)
}

connectedCallback(): void {
if (!this.hasAttribute('role')) {
this.setAttribute('role', 'toolbar')
}
if (!this.hasAttribute('data-no-focus')) {
setFocusManagement(this)
}
this.addEventListener('keydown', keydown(applyFromToolbar))
this.addEventListener('click', applyFromToolbar)
}

attributeChangedCallback(name: string, oldValue: string, newValue: string): void {
Expand Down
12 changes: 12 additions & 0 deletions test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -921,6 +921,18 @@ describe('markdown-toolbar-element', function () {

assert.equal('###### |title|', visualValue())
})

it('applies a data-md-button style once from the keyboard after the toolbar is moved', function () {
const headerElement = document.createElement('button')
headerElement.setAttribute('data-md-button', 'header-6')
const toolbar = document.querySelector('markdown-toolbar')
toolbar.appendChild(headerElement)
toolbar.parentElement.append(toolbar)
setVisualValue('|title|')
headerElement.dispatchEvent(new KeyboardEvent('keydown', {key: 'Enter', bubbles: true, cancelable: true}))

assert.equal('###### |title|', visualValue())
})
})
})
})