Skip to content

fix: retain event hooks when override omits events #5102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shubham-Padkonde wants to merge 1 commit into
base: main
Choose a base branch
from
+25 −1
Open

fix: retain event hooks when override omits events #5102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/specify_cli/events/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -997,7 +997,7 @@ def resolve_events(
override_file, integration_key,
)
else:
key_events = key_data.get("events", {})
key_events = key_data.get("events")
if not isinstance(key_events, dict):
logger.warning(
"Override %s: 'events' for '%s' is not a mapping; ignoring override",
Expand Down
24 changes: 24 additions & 0 deletions tests/specify_cli/events/test_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2988,6 +2988,30 @@ class TestOverridePreserveLayers:
the accumulated built-in + extension layers, instead of disabling all
hooks."""

@pytest.mark.parametrize("entry", ["{}", "{evnts: {stop: {command: speckit.typo}}}"])
def test_missing_events_field_keeps_prior_layers(self, tmp_path, caplog, entry):
ext_dir = tmp_path / ".specify" / "extensions" / "my-ext"
ext_dir.mkdir(parents=True)
(ext_dir / "extension.yml").write_text(
"events:\n session_start:\n command: speckit.my-ext.boot\n",
encoding="utf-8",
)
override_file = tmp_path / ".specify" / "integration-events.yml"
override_file.write_text(f"integrations:\n claude: {entry}\n", encoding="utf-8")

result = resolve_events(
"claude",
{"events": {"post_tool_use": {"command": "speckit.tdd.validate"}}},
tmp_path,
None,
)

assert result == {
"post_tool_use": [{"command": "speckit.tdd.validate"}],
"session_start": [{"command": "speckit.my-ext.boot"}],
}
assert "'events' for 'claude' is not a mapping; ignoring override" in caplog.text

def test_invalid_override_entry_keeps_prior_layers(self, tmp_path):
override_file = tmp_path / ".specify" / "integration-events.yml"
override_file.parent.mkdir(parents=True, exist_ok=True)
Expand Down