refactor(sonar): avoid awaiting promises sequentially in loops (typescript:S9382) - #3358
Merged
Merged
Conversation
setchy
marked this pull request as ready for review
October 3, 2026 21:24
afonsojramos
approved these changes
Oct 4, 2026
afonsojramos
approved these changes
Oct 4, 2026
setchy
enabled auto-merge (squash)
October 4, 2026 01:45
|
Contributor
|
🎉 This pull request is included in Gitify v7.9.0! 🎉 Downloads for macOS, Windows, and Linux are available on the release page. Thanks for helping make Gitify better! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SonarCloud:
typescript:S9382(filtered issues)Resolves Sonar rule typescript:S9382 — Promises should not be awaited sequentially in a loop (3 issues).
useLogins.ts: run account cache pruning withPromise.allinstead of awaiting in aforloop.enrich.ts: fetch GraphQL detail batches concurrently withPromise.all(per-batch error logging preserved).LoginWithDeviceFlow.tsx: replace the pollingwhileloop with a recursivepollso the poll/sleep sequence no longer awaits inside a loop.Lint,
tsc, and the full test suite pass.